Avoid generate duplicated files for install command. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module headers are already added in the top `Makefile.am`, which is introduced in 91fae3a, but the module `Makefile.am.include` will add the headers again. Steps to reproduce the issue: ./autogen.sh ./configure --enable-module-recovery --prefix /tmp/secp256k1 make make install Failure message: /usr/bin/install -c -m 644 include/secp256k1.h include/secp256k1_ecdh.h include/secp256k1_recovery.h include/secp256k1_recovery.h '/usr/local/include' /usr/bin/install: will not overwrite just-created '/usr/local/include/secp256k1_recovery.h' with 'include/secp256k1_recovery.h' Makefile:1151: recipe for target 'install-includeHEADERS' failed make[1]: *** [install-includeHEADERS] Error 1 make[1]: Leaving directory '/home/travis/secp256k1' Makefile:1578: recipe for target 'install-am' failed make: *** [install-am] Error 2 Closes bitcoin-core#624
|
Drat. AFAICT simply reverting the merge is actually the correct fix. Do you agree? If so I would appreciate changing your PR to just a revert. |
doitian
added a commit
to doitian/secp256k1
that referenced
this pull request
May 24, 2019
This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in bitcoin-core#625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments.
I created another one to do the revert. Pick one and close the other. |
gmaxwell
added a commit
that referenced
this pull request
May 24, 2019
662918c Revert "Merge #620: Install headers automatically" (ian) Pull request description: This reverts commit 91fae3a, reversing changes made to 5df77a0. See discussion in #625 After the change, if we enable any module, `make install` fails because of the duplicated files in the command line arguments. Closes #624 Tree-SHA512: 7769ede527ac307bff094603e5974c56b19e41bc2ef55113173d3dbc8e545d6add7ae044753fa0361595e5e7a746d6c8d641f98caa3381b683aa2b61a1742097
|
Resolved by #626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module headers are already added in the top
Makefile.am, which isintroduced in 91fae3a, but the module
Makefile.am.includewill add the headers again.Steps to reproduce the issue:
Failure message:
Closes #624