Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run a Travis test on s390x (big endian) #696

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Run a Travis test on s390x (big endian) #696

merged 1 commit into from
Aug 7, 2020

Conversation

sipa
Copy link
Contributor

@sipa sipa commented Nov 28, 2019

No description provided.

@sipa
Copy link
Contributor Author

sipa commented Nov 28, 2019

checking whether byte ordering is bigendian... yes

\o/

@elichai
Copy link
Contributor

elichai commented Nov 28, 2019 •
edited
Loading

It worked on core :P
But still satisfying to see.
There's nothing more satisfying than seeing that your code works on an edge case you never tested before lol

@jonasnick
Copy link
Contributor

Cool! What's missing for un-WIP'ing? How about turning on the ECDH and recovery module?

@real-or-random real-or-random mentioned this pull request Jan 6, 2020
Open
@real-or-random real-or-random mentioned this pull request Jul 21, 2020
Closed
@real-or-random
Copy link
Contributor

Cool! What's missing for un-WIP'ing? How about turning on the ECDH and recovery module?

@sipa Could you do this, and maybe also add a comment to the Travis file that this is a big-endian host?

@elichai elichai mentioned this pull request Jul 28, 2020
Closed
maflcko
maflcko reviewed Jul 28, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@sipa sipa changed the title [WIP] Let's see if s390x testing works Run a Travis test on s390x (big endian) Jul 29, 2020
@sipa
Copy link
Contributor Author

sipa commented Jul 29, 2020

Rebased, and added ECDH/recovery.

I did notice valgrind ctime test failure on this line in src/scalar_4x64_impl.h:

    no |= (a->d[1] < SECP256K1_N_1);

so I've disabled the ctime test for now.

@real-or-random
Copy link
Contributor 

    no |= (a->d[1] < SECP256K1_N_1);

and two lines below too:

https://github.com/bitcoin-core/secp256k1/blob/master/src/scalar_4x64_impl.h#L65

so I've disabled the ctime test for now.

makes sense.

real-or-random
real-or-random requested changes Jul 29, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@real-or-random
Copy link
Contributor

ACK c5e43bb Travis works and says it's big endian

The travis failure is a randomness test again (#68), see https://travis-ci.org/github/bitcoin-core/secp256k1/jobs/713125311#L497

If you want, you can squash this. Otherwise I'll just merge it in the next days if noone objects.

@elichai elichai mentioned this pull request Jul 30, 2020
Merged
real-or-random
real-or-random approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3929536 Travis works and says it's big endian

(I squashed this for merging).

@real-or-random real-or-random merged commit 805082d into bitcoin-core:master Aug 7, 2020
@real-or-random real-or-random mentioned this pull request Aug 8, 2020
Merged
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 29, 2020
@sipa @Fabcien
Run a Travis test on s390x (big endian)
f7cc6a9 
Summary:
Since there is no cmake binary available for this architecture, the
Ubuntu Focal distribution is used which has a cmake 3.16 port for s390x.

Backport of secp256k1 [[bitcoin-core/secp256k1#696 | PR696]].

Depends on D7610.

Test Plan:
Run the travis build.
https://travis-ci.org/github/Fabcien/secp256k1/builds/731209990

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7630
deadalnix pushed a commit to Bitcoin-ABC/secp256k1 that referenced this pull request Sep 30, 2020
@sipa @Fabcien
Run a Travis test on s390x (big endian)
a894289 
Summary:
Since there is no cmake binary available for this architecture, the
Ubuntu Focal distribution is used which has a cmake 3.16 port for s390x.

Backport of secp256k1 [[bitcoin-core/secp256k1#696 | PR696]].

Depends on D7610.

Test Plan:
Run the travis build.
https://travis-ci.org/github/Fabcien/secp256k1/builds/731209990

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko left review comments

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sipa @elichai @jonasnick @real-or-random @maflcko