-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bdk_wallet to alpha 13 #561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
chore/alpha13
branch
4 times, most recently
from
June 20, 2024 18:22
acefa76
to
542ac66
Compare
3 tasks
thunderbiscuit
force-pushed
the
chore/alpha13
branch
2 times, most recently
from
June 24, 2024 14:13
0420b95
to
2c70892
Compare
thunderbiscuit
force-pushed
the
chore/alpha13
branch
from
June 24, 2024 14:16
2c70892
to
3b89af5
Compare
thunderbiscuit
force-pushed
the
chore/alpha13
branch
2 times, most recently
from
June 26, 2024 20:06
5bc6483
to
7ed3366
Compare
thunderbiscuit
force-pushed
the
chore/alpha13
branch
from
June 27, 2024 12:52
94d4995
to
e2abc36
Compare
thunderbiscuit
force-pushed
the
chore/alpha13
branch
from
June 27, 2024 16:33
563af80
to
ffe0c8c
Compare
thunderbiscuit
force-pushed
the
chore/alpha13
branch
from
June 27, 2024 19:25
14e7a5c
to
7e5897b
Compare
reez
reviewed
Jul 1, 2024
reez
reviewed
Jul 1, 2024
reez
reviewed
Jul 1, 2024
reez
reviewed
Jul 1, 2024
reez
reviewed
Jul 1, 2024
reez
reviewed
Jul 1, 2024
reez
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of our biggest bumps on the alpha train. Take your time with the review, there is just so much. I'm sorry I wasn't really able to break it into many smaller commits, it was all a jungle of changes that needed to happen together.
Notes for reviewers
Error
, and you know what type of error they are from their fully qualified name (for examplebdk_wallet::bitcoin::address::Error
is an error tied to theAddress
type. This metadata available to Rust users is erased when building the bindings because all our errors exist as top-level errors. This means that at face value we'd have a ton of specific errors just calledError
. When these happen, I instead try to rename the error using part of the fully qualified name so users of the bindings have a better idea what those errors are at first glance; but this means there is a bit of art/subjectivity to it rather than pure exposing of the exact same name. Feel free to comment on my choice of names for the errors.Address.network()
method with bitcoin 0.32. I don't know what's going on with this type honestly, they just keep changing it. I can't remember exactly how that might impact the workflow Jurvis was telling us about, but the method does not exist on the type anymore, so I assume there must be other ways to achieve the same security as what he was intending to do. Will need to confirm.Description
This PR bumps the Rust libraries to the alpha 13 release.
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: