Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uniffi to 0.28.0 #562 #564

Merged

Conversation

ItoroD
Copy link
Contributor

@ItoroD ItoroD commented Jun 21, 2024

Description

Bump uniffi to 0.28.0 Just to keep up with the latest releases and features.

Changelog notice

  • updated the version of uniffi to 0.28.0

Checklists

All Submissions:

Bugfixes:

@thunderbiscuit thunderbiscuit self-requested a review June 24, 2024 12:52
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! The only thing I'd need changed is the commit message format to comply with BDK's standard. In this case it would probably look something like this:

chore: bump uniffi to 0.28.0

I think I might try to rebase #561 on this one if @reez is cool with merging this bump before the alpha 13 changes.

@ItoroD ItoroD force-pushed the Bump-uniffi-to-0.28.0-#562 branch from d7a9913 to 92aeeab Compare June 24, 2024 13:40
@reez
Copy link
Collaborator

reez commented Jun 24, 2024

Thanks for taking this on! The only thing I'd need changed is the commit message format to comply with BDK's standard. In this case it would probably look something like this:

chore: bump uniffi to 0.28.0

I think I might try to rebase #561 on this one if @reez is cool with merging this bump before the alpha 13 changes.

Sounds good to me, I saw commit message just get changed so I made sure the CI started running again by hitting "Approve and Run"

@ItoroD
Copy link
Contributor Author

ItoroD commented Jun 24, 2024

Thanks @reez

@thunderbiscuit Thanks. I am taking note of the BDK commit message standard

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Jun 24, 2024

Awesome. Looks ready to go. I was thinking about how they often ship really cool stuff and we should really take the time to parse through the changelog, and the PR for the bump is a really good place to do this. I think in the future, we should require that the PR message contains the changelog for the bump. How does that sound? For this one I'll paste it here.

Uniffi 0.28.0 Changelog

v0.28.0 (backend crates: v0.28.0) - (2024-06-11)

What's new?

  • Objects error types can now be as Result<> error type without wrapping them in Arc<>.

  • Swift errors now provide localizedDescription (#2116)

  • Procmacros support tuple-errors (ie, enums used as errors can be tuple-enums.)

What's fixed?

  • Fixed a problem with procmacro defined errors when the error was not used as an Err result
    in the namespace (#2108)

  • Custom Type names are now treated as type names by all bindings. This means if they will work if they happen to be
    keywords in the language. There's a very small risk of this being a breaking change if you used a type name which
    did not already start with a capital letter, but this changes makes all type naming consistent.
    (#2073)

  • Macros uniffi::method and uniffi::constructor can now be used with
    cfg_attr. (#2113)

  • Python: Fix custom types generating invalid code when there are forward references.
    (#2067)

What's changed?

  • The internal bindings generation has changed to make it friendlier for external language bindings.
    However, this a breaking change for these bindings.
    No consumers of any languages are impacted, only the maintainers of these language bindings.
    (#2066), (#2094)

  • The async runtime can be specified for constructors/methods, this will override the runtime specified at the impl block level.

All changes in v0.28.0.

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 92aeeab.

@thunderbiscuit thunderbiscuit merged commit 92aeeab into bitcoindevkit:master Jun 24, 2024
25 checks passed
@reez
Copy link
Collaborator

reez commented Jun 24, 2024

Awesome. Looks ready to go. I was thinking about how they often ship really cool stuff and we should really take the time to parse through the changelog, and the PR for the bump is a really good place to do this. I think in the future, we should require that the PR message contains the changelog for the bump. How does that sound? For this one I'll paste it here.

Uniffi 0.28.0 Changelog

v0.28.0 (backend crates: v0.28.0) - (2024-06-11)

What's new?

  • Objects error types can now be as Result<> error type without wrapping them in Arc<>.
  • Swift errors now provide localizedDescription (#2116)
  • Procmacros support tuple-errors (ie, enums used as errors can be tuple-enums.)

What's fixed?

  • Fixed a problem with procmacro defined errors when the error was not used as an Err result
    in the namespace (#2108)
  • Custom Type names are now treated as type names by all bindings. This means if they will work if they happen to be
    keywords in the language. There's a very small risk of this being a breaking change if you used a type name which
    did not already start with a capital letter, but this changes makes all type naming consistent.
    (#2073)
  • Macros uniffi::method and uniffi::constructor can now be used with
    cfg_attr. (#2113)
  • Python: Fix custom types generating invalid code when there are forward references.
    (#2067)

What's changed?

  • The internal bindings generation has changed to make it friendlier for external language bindings.
    However, this a breaking change for these bindings.
    No consumers of any languages are impacted, only the maintainers of these language bindings.
    (#2066), (#2094)
  • The async runtime can be specified for constructors/methods, this will override the runtime specified at the impl block level.

All changes in v0.28.0.

Great idea, will try to remember this for the future-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants