-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump uniffi to 0.28.0 #562 #564
Bump uniffi to 0.28.0 #562 #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! The only thing I'd need changed is the commit message format to comply with BDK's standard. In this case it would probably look something like this:
chore: bump uniffi to 0.28.0
I think I might try to rebase #561 on this one if @reez is cool with merging this bump before the alpha 13 changes.
d7a9913
to
92aeeab
Compare
Sounds good to me, I saw commit message just get changed so I made sure the CI started running again by hitting "Approve and Run" |
Thanks @reez @thunderbiscuit Thanks. I am taking note of the BDK commit message standard |
Awesome. Looks ready to go. I was thinking about how they often ship really cool stuff and we should really take the time to parse through the changelog, and the PR for the bump is a really good place to do this. I think in the future, we should require that the PR message contains the changelog for the bump. How does that sound? For this one I'll paste it here. Uniffi 0.28.0 Changelogv0.28.0 (backend crates: v0.28.0) - (2024-06-11)What's new?
What's fixed?
What's changed?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 92aeeab.
Great idea, will try to remember this for the future- |
Description
Bump uniffi to 0.28.0 Just to keep up with the latest releases and features.
Changelog notice
Checklists
All Submissions:
Bugfixes: