Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esplora-client #830

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Update esplora-client #830

merged 1 commit into from
Jan 3, 2023

Conversation

rajarshimaitra
Copy link
Contributor

@rajarshimaitra rajarshimaitra commented Dec 29, 2022 •
edited
Loading

Description

Update esplora-client and electrsd.

Update: electrsd v0.22 requires msrv at 1.57.. So removed from the PR for now..

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rajarshimaitra rajarshimaitra changed the title Update esplora-client and electrsd Update esplora-client Dec 30, 2022
benthecarman
benthecarman approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice to get in before the next release

notmandatory
notmandatory approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4d8ea88

@notmandatory
Copy link
Member

@rajarshimaitra can you update the commit message also to remove the part about electrsd changing? Then we should be able to get this into 0.26.0.

@rajarshimaitra
Copy link
Contributor Author

Done..

@notmandatory notmandatory merged commit eac739d into bitcoindevkit:master Jan 3, 2023
@notmandatory notmandatory mentioned this pull request Jan 4, 2023
Closed
24 tasks
@notmandatory
Copy link
Member

@rajarshimaitra hey sorry but I think we may need to roll this one back. There's some dependency for esplora-client that doesn't work with our MSRV 1.56.1. We either need to get esplora-client to work with 1.56.1 or will need to update bdk MSRV to 1.57.0.

see: https://github.com/bitcoindevkit/bdk/actions/runs/3999121592/jobs/6862629601

cargo tree -i -p rustls@0.20.8 --features minimal,use-esplora-blocking --no-default-features
rustls v0.20.8
└── ureq v2.6.2
    └── esplora-client v0.3.0
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)
    [build-dependencies]
    └── electrsd v0.21.1
        [dev-dependencies]
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)

@notmandatory
Copy link
Member

I made this issue to add MSRV tests in esplora-client bitcoindevkit/rust-esplora-client#35

@notmandatory
Copy link
Member

Ugh, looks like rustls changed their MSRV to 1.57 on 2023-01-12 with a point release from 0.20.7 to 0.20.8, rustls/rustls#1152. 😞

https://github.com/rustls/rustls/blob/main/README.md

@notmandatory
Copy link
Member

I created a PR to change BDK MSRV to 1.57.0, we can discuss more here: #842

@notmandatory notmandatory mentioned this pull request Jan 31, 2023
Merged
2 tasks
notmandatory added a commit that referenced this pull request Feb 2, 2023
@notmandatory
Merge #847: Update electrsd to version 0.22
46273fe 
147a4ed Update electrsd to version 0.22 (Steve Myers)

Pull request description:

  ### Description

  Update `electrsd` dev-dependency to version `0.22`.

  ### Notes to the reviewers

  We're able to do this now that esplora was updated in #830 and our MSRV was bumped to `1.57.0` in #842.

  ### Changelog

  None.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  rajarshimaitra:
    ACK 147a4ed

Tree-SHA512: 20e0aebb02d786a4d426a2d2e66b78225a803eee2c2f6092b0cf8f18e6fe91e37ef7a74e109e3ad4d734af8de4dc71598f7e80f50d40187442dad323000c6090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@benthecarman benthecarman benthecarman approved these changes

Assignees

@rajarshimaitra rajarshimaitra

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.26.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@rajarshimaitra @notmandatory @benthecarman