Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to also test with MSRV #35

Closed
notmandatory opened this issue Jan 24, 2023 · 2 comments
Closed

Update CI to also test with MSRV #35

notmandatory opened this issue Jan 24, 2023 · 2 comments
Labels
ci Continuous Integration issues

Comments

@notmandatory
Copy link
Member

Looks like there was some a change in the dependencies for esplora-client 0.3 and CI is failing on bdk with it's MSRV 1.56.1. The CI for this project should be updated to test with rust stable and MSRV. Then we'll have to decide also what MSRV to use, ideally should be same as bdk but if not possible then bdk can keep using 0.2 for this project until able to update it's MSRV.

see: https://github.com/bitcoindevkit/bdk/actions/runs/3999121592/jobs/6862629601

cargo tree -i -p rustls@0.20.8 --features minimal,use-esplora-blocking --no-default-features
rustls v0.20.8
└── ureq v2.6.2
    └── esplora-client v0.3.0
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)
    [build-dependencies]
    └── electrsd v0.21.1
        [dev-dependencies]
        └── bdk v0.26.0 (/Users/steve/git/notmandatory/bdk)
@notmandatory notmandatory added the ci Continuous Integration issues label Jan 24, 2023
@notmandatory
Copy link
Member Author

Ugh, looks like rustls changed their MSRV to 1.57 on 2023-01-12 with a point release from 0.20.7 to 0.20.8, rustls/rustls#1152. 😞

https://github.com/rustls/rustls/blob/main/README.md

@notmandatory
Copy link
Member Author

I created a PR to change BDK MSRV to 1.57.0, we can discuss more here: bitcoindevkit/bdk#842

vladimirfomene pushed a commit to vladimirfomene/rust-esplora-client that referenced this issue Jan 25, 2023
This PR solves issue bitcoindevkit#35

Signed-off-by: vladimirfomene <vladimirfomene@gmail.com>
vladimirfomene pushed a commit to vladimirfomene/rust-esplora-client that referenced this issue Feb 2, 2023
vladimirfomene added a commit that referenced this issue Feb 2, 2023
cabe620 Test against stable and MSRV Rust versions. (root)

Pull request description:

  This PR solves issue #35

Top commit has no ACKs.

Tree-SHA512: 51bca1114dc696d562363787f1bb9b0ca3d1b3644744c8f4cce734dd128807946ed278b0dd44b6de46edda424494dc8b81cc11081ee7dd7754ee646ed52fa7d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues
Projects
None yet
Development

No branches or pull requests

2 participants