-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test electrum ext #979
Test electrum ext #979
Conversation
56da08d
to
b5aca1a
Compare
@vladimirfomene This doesn't seem to build for Also, could you provide more details for the failing tests? Thank you. |
7898945
to
3734a5c
Compare
3734a5c
to
7117f3d
Compare
@evanlinjin, was able to get the test to compile with 1.57. Here are the two errors I occasionally get. |
We have a bug in #1145 that having tests like this PR introduced may have caught. I think we want to introduce a test in that PR to reproduce the issue. If this PR already reproduces the issue then we could use this one. In any case the groundwork here should be useful. I think this PR can be improved by not using concepts like @vladimirfomene wdyt? |
Test coverage is good for electrum client see #906. We can add more testing for new scenarios as needed. Closing this PR as it's out of date. |
Description
This PR tests our Electrum scanning logic
Notes to the reviewers
I will leave this in draft for now because the test still occasionally fail. I'm still trying to figure out why but the root cause of the bug is hard to find because the bug occurs occasionally.
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing