Switch from create-hash, pbkdf2, randombytes to noble-hashes #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't know what happens with nyc, it thinks mnemonicToEntropy branches are not covered. Just in case i've replicated validateMnemonic with |
junderw
approved these changes
Feb 25, 2023
Member
junderw
left a comment
junderw
left a comment
There was a problem hiding this comment.
Weird... we need to move away from nyc eventually... legacy code.
LGTM
Member
|
Published as v3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch 3.x was failing due to ESM error. Locked to latest 2.x.
test('README examplewas failing due torandombytesmodule being mocked. New impl uses function inside noble-hashes which I don't know how to mock.