-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Switch from create-hash, ripemd160 to noble-hashes #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe we should do bip39 and bs58check first, then cut releases for those and then do this. |
|
What do you think regarding merging those? |
|
Would you mind converting the travis yml to a Github CI yml so that it can run the tests on the PR? Thanks. (Edit: referring to the 2 PRs you linked) |
|
Done. Copy-pasted your ci config from the repository and adjusted a bit. All tests are passing. |
|
I have merged and published everything. Please remove create-hash 🎉 |
Maybe ChatGPT can help with this. lol |
|
That did not help. wif still depends on old stuff. regtest-client also does, but it's devDependency - probably not worth to upgrade; users won't see create-hash after bitcoinjs upgrade already. |
|
Is wif even used outside tests? |
|
Not used anywhere, actually. Removed, all good now. create-hash became devDependency. |
|
Seems good to go! |
|
@junderw ping |
hash160,hash256methods were adjusted because it's more performant to not do Buffer.from twice. I suppose some future update of bitcoinjs will remove buffer altogether.create-hash and ripemd160 were not removed from dependency tree. Reasons: