Skip to content

Conversation

@paulmillr
Copy link
Contributor

hash160, hash256 methods were adjusted because it's more performant to not do Buffer.from twice. I suppose some future update of bitcoinjs will remove buffer altogether.

create-hash and ripemd160 were not removed from dependency tree. Reasons:

  • bip32: needs a new release
  • bip39, bs58check: need switch to hashes

@junderw
Copy link
Member

junderw commented Feb 17, 2023

Maybe we should do bip39 and bs58check first, then cut releases for those and then do this.

@paulmillr
Copy link
Contributor Author

@paulmillr
Copy link
Contributor Author

What do you think regarding merging those?

@junderw
Copy link
Member

junderw commented Feb 24, 2023

Would you mind converting the travis yml to a Github CI yml so that it can run the tests on the PR?

Thanks.

(Edit: referring to the 2 PRs you linked)

@paulmillr
Copy link
Contributor Author

Done. Copy-pasted your ci config from the repository and adjusted a bit. All tests are passing.

@junderw
Copy link
Member

junderw commented Feb 25, 2023

I have merged and published everything.

Please remove create-hash 🎉

@junderw
Copy link
Member

junderw commented Feb 25, 2023

I suppose some future update of bitcoinjs will remove buffer altogether.

Maybe ChatGPT can help with this. lol

@paulmillr
Copy link
Contributor Author

That did not help. wif still depends on old stuff.

bitcoinjs/wif#30

regtest-client also does, but it's devDependency - probably not worth to upgrade; users won't see create-hash after bitcoinjs upgrade already.

@junderw
Copy link
Member

junderw commented Feb 25, 2023

Is wif even used outside tests?

@paulmillr
Copy link
Contributor Author

Not used anywhere, actually. Removed, all good now. create-hash became devDependency.

@paulmillr
Copy link
Contributor Author

Seems good to go!

@paulmillr
Copy link
Contributor Author

@junderw ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants