Upgrade bs58check. Drop safe-buffer #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wish this merged and npm publish, so that |
Contributor
Author
|
@junderw ping |
junderw
approved these changes
Aug 29, 2023
Member
|
Tried publishing 3.0.0 (bump major) only to find 2 versions 3.0.0 and 3.0.1 on npmjs not on Github. The tags were there, but the commits weren't on any branch... Perhaps I messed up something when publishing 2.0.6. I checked the diffs and the only thing that changed was removing the 32 byte check for private keys. (not sure why) I published as 4.0.0 |
|
Thanks @junderw ! I made PR for bip32 bitcoinjs/bip32#81 which upgrade wif version there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.