Skip to content

Conversation

@jnewbery
Copy link
Contributor

closes #11

Adds motivation quotes. I don't think this looks very good at the moment. Perhaps we should use the two column layout from #9.

Also need to add thumbnails and quotes from @harding and @marcinja (assuming you guys want that?)

@harding
Copy link
Collaborator

harding commented Jun 29, 2018

I feel silly making up quotes, but here's one that sounds suitably corny:

The terrible thing about a consensus system like Bitcoin is that every on-chain action we perform affects every other user of the system. That makes all of us neighbors, so we're faced with the choice of either being the bad neighbors who complain endlessly about each other or the good neighbors who work together to solve problems and find ways to coexist in harmony.

@jnewbery
Copy link
Contributor Author

Updated the about page to use the two-column layout and added avators & quotes.

Ready for review.

@marcinja - do you want to add a quote to the about page?

@harding
Copy link
Collaborator

harding commented Jul 10, 2018

Looks fine to me. I do suggest eliminating some of the vertical whitespace; also the GitHub octocat icon is a bit hard to recognize, so I suggest dropping the fixed-width specifier (fa-fw), maybe bumping it up to a large icon (fa-lg), and moving it outside of the blue hyperlink. Here's what that would look like:

2018-07-10-11_19_38_511774089

And here's a diff:

diff --git a/_includes/associates.html b/_includes/associates.html
index 4efec1e..6544f59 100644
--- a/_includes/associates.html
+++ b/_includes/associates.html
@@ -9,8 +9,8 @@
         <li>
             <img src="{{ avatar }}" class="bio-photo" width="150" height="150" alt="{{ associate.name }}" title="{{ associate.name }}">
             <h3 itemprop="name">{{ associate.name }}</h3>
-            <p>{{ associate.role }} {% if associate.other_affiliation %}<br/>{{ associate.other_affiliation }}{% endif %}</p>
-            <a href="https://github.com/{{ associate.github }}" class="author-github" target="_blank"><i class="fa fa-fw fa-github-square" rel="nofollow"></i>GitHub</a>
+            <p class="author-role">{{ associate.role }} {% if associate.other_affiliation %}<br/>{{ associate.other_affiliation }}{% endif %}</p>
+            <i class="fa fa-lg fa-github-square" rel="nofollow"></i>&nbsp;<a href="https://github.com/{{ associate.github }}" class="author-github" target="_blank">GitHub</a>
            {% if associate.quote %}<p class="sponsor-quote">{{ associate.quote }} </p>{% endif %}
         </li>
         {% endfor %}
diff --git a/assets/css/main.scss b/assets/css/main.scss
index 4134fde..258e96a 100644
--- a/assets/css/main.scss
+++ b/assets/css/main.scss
@@ -54,3 +54,7 @@ p.sponsor-quote {
         max-width: 100%;
         box-shadow: 0 0 0 1px rgba(0,0,0,0.2);
 }
+
+.author-role {
+        margin-bottom: 0;
+}

@marcinja
Copy link
Contributor

Sure. Here's my quote:

I'm interested in helping make Bitcoin better, and an important step forward is getting the community to use Bitcoin more efficiently. I hope that Optech can help coordinate this effort, and others, to make it as great as possible.

@jnewbery
Copy link
Contributor Author

Taken @harding diff, added @marcinja quote and rebased

@jnewbery
Copy link
Contributor Author

@jamesob @moneyball - do you mind testing/reviewing?

@jamesob
Copy link
Contributor

jamesob commented Jul 11, 2018

Tested ACK - looks great!

@jamesob
Copy link
Contributor

jamesob commented Jul 11, 2018

@harding's quote is 💯.

@jnewbery jnewbery merged commit 04927a1 into bitcoinops:master Jul 12, 2018
harding referenced this pull request in harding/bitcoinops.github.io Sep 10, 2018
jnewbery added a commit that referenced this pull request Sep 11, 2018
@jnewbery jnewbery deleted the update_about branch October 8, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add team member information

4 participants