-
Notifications
You must be signed in to change notification settings - Fork 145
Add motivation quotes #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I feel silly making up quotes, but here's one that sounds suitably corny:
|
|
Updated the about page to use the two-column layout and added avators & quotes. Ready for review. @marcinja - do you want to add a quote to the about page? |
|
Looks fine to me. I do suggest eliminating some of the vertical whitespace; also the GitHub octocat icon is a bit hard to recognize, so I suggest dropping the fixed-width specifier (fa-fw), maybe bumping it up to a large icon (fa-lg), and moving it outside of the blue hyperlink. Here's what that would look like: And here's a diff: diff --git a/_includes/associates.html b/_includes/associates.html
index 4efec1e..6544f59 100644
--- a/_includes/associates.html
+++ b/_includes/associates.html
@@ -9,8 +9,8 @@
<li>
<img src="{{ avatar }}" class="bio-photo" width="150" height="150" alt="{{ associate.name }}" title="{{ associate.name }}">
<h3 itemprop="name">{{ associate.name }}</h3>
- <p>{{ associate.role }} {% if associate.other_affiliation %}<br/>{{ associate.other_affiliation }}{% endif %}</p>
- <a href="https://github.com/{{ associate.github }}" class="author-github" target="_blank"><i class="fa fa-fw fa-github-square" rel="nofollow"></i>GitHub</a>
+ <p class="author-role">{{ associate.role }} {% if associate.other_affiliation %}<br/>{{ associate.other_affiliation }}{% endif %}</p>
+ <i class="fa fa-lg fa-github-square" rel="nofollow"></i> <a href="https://github.com/{{ associate.github }}" class="author-github" target="_blank">GitHub</a>
{% if associate.quote %}<p class="sponsor-quote">{{ associate.quote }} </p>{% endif %}
</li>
{% endfor %}
diff --git a/assets/css/main.scss b/assets/css/main.scss
index 4134fde..258e96a 100644
--- a/assets/css/main.scss
+++ b/assets/css/main.scss
@@ -54,3 +54,7 @@ p.sponsor-quote {
max-width: 100%;
box-shadow: 0 0 0 1px rgba(0,0,0,0.2);
}
+
+.author-role {
+ margin-bottom: 0;
+} |
|
Sure. Here's my quote:
|
|
@jamesob @moneyball - do you mind testing/reviewing? |
|
Tested ACK - looks great! |
|
@harding's quote is 💯. |
Newsletters: add #12 (2018-09-11)

closes #11
Adds motivation quotes. I don't think this looks very good at the moment. Perhaps we should use the two column layout from #9.
Also need to add thumbnails and quotes from @harding and @marcinja (assuming you guys want that?)