-
Notifications
You must be signed in to change notification settings - Fork 145
Add sponsors to index page #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@harding - this adds the data, but it doesn't look very good yet! It'd be nice if we could have the sponsors presented in a grid, similar to how the contributors were shown in bitcoincore.org prior to bitcoin-core/bitcoincore.org@c8618b1. Is that possible within the minimal jekyll theme that we're using? |
|
I've added fontawesome to address the comment here: #10 (comment) . @harding - do the last two commits look like the right approach? I'm still waiting to get a good quote from Wences, and probably also update the quote from Chaincode. |
|
@jnewbery LGTM with one suggestion: diff --git a/assets/css/main.scss b/assets/css/main.scss
index 6e2907b..91a0511 100644
--- a/assets/css/main.scss
+++ b/assets/css/main.scss
@@ -34,11 +34,13 @@ br.clear {
p.sponsor-quote {
font-style: italic;
+ margin-top: 20px;
}
.sponsors h3 {
font-weight: 700;
font-size: 120%;
+ margin-bottom: 0;
}
// The long text quotes make this application of a two-column listCurrently it's, This makes it, Which seems more natural to me. |
|
Updated CSS as suggested by harding, and added quote for Chaincode. Just need to wait for Wences quote. |
|
rebased |
|
I have approval for all three quotes from the sponsors, so I think this is ready for merge. @harding / @moneyball - are you happy for this to go in? |
harding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK ff20bcc
Newsletters: add #9 (2018-08-21)

This adds our sponsors to the home page.