Skip to content

Conversation

@jnewbery
Copy link
Contributor

This adds our sponsors to the home page.

@jnewbery
Copy link
Contributor Author

@harding - this adds the data, but it doesn't look very good yet!

It'd be nice if we could have the sponsors presented in a grid, similar to how the contributors were shown in bitcoincore.org prior to bitcoin-core/bitcoincore.org@c8618b1. Is that possible within the minimal jekyll theme that we're using?

@jnewbery
Copy link
Contributor Author

I've added fontawesome to address the comment here: #10 (comment) . @harding - do the last two commits look like the right approach?

I'm still waiting to get a good quote from Wences, and probably also update the quote from Chaincode.

@harding
Copy link
Collaborator

harding commented Jun 29, 2018

@jnewbery LGTM with one suggestion:

diff --git a/assets/css/main.scss b/assets/css/main.scss
index 6e2907b..91a0511 100644
--- a/assets/css/main.scss
+++ b/assets/css/main.scss
@@ -34,11 +34,13 @@ br.clear {
 
 p.sponsor-quote {
         font-style: italic;
+        margin-top: 20px;
 }
 
 .sponsors h3 {
         font-weight: 700;
         font-size: 120%;
+        margin-bottom: 0;
 }
 
 // The long text quotes make this application of a two-column list

Currently it's,

Name

Twitter
Paragraph of text

This makes it,

Name
Twitter link

Paragraph of text

Which seems more natural to me.

2018-06-29-13_13_34_084547150

@jnewbery
Copy link
Contributor Author

Updated CSS as suggested by harding, and added quote for Chaincode. Just need to wait for Wences quote.

@jnewbery
Copy link
Contributor Author

jnewbery commented Jul 9, 2018

rebased

@jnewbery
Copy link
Contributor Author

I have approval for all three quotes from the sponsors, so I think this is ready for merge.

@harding / @moneyball - are you happy for this to go in?

Copy link
Collaborator

@harding harding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK ff20bcc

@jnewbery jnewbery merged commit 5b3932c into master Jul 10, 2018
@jnewbery jnewbery deleted the sponsors branch July 10, 2018 15:03
harding referenced this pull request in harding/bitcoinops.github.io Aug 19, 2018
jnewbery referenced this pull request in harding/bitcoinops.github.io Aug 21, 2018
jnewbery added a commit that referenced this pull request Aug 21, 2018
marcinja pushed a commit to marcinja/bitcoinops.github.io that referenced this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants