Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/ghost] Release 19.1.10 #12478

Merged
merged 6 commits into from
Sep 21, 2022
Merged

[bitnami/ghost] Release 19.1.10 #12478

merged 6 commits into from
Sep 21, 2022

Conversation

bitnami-bot
Copy link
Contributor

This is an automated Pull Request updating (all or part of):

  • App version: 5.15.0.
  • Chart version: 19.1.10.
  • Immutable tags inside the values files:
    • docker.io/bitnami/ghost:5.15.0-debian-11-r0
    • docker.io/bitnami/bitnami-shell:11-debian-11-r36

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@github-actions github-actions bot added the verify Execute verification workflow for these changes label Sep 19, 2022
@github-actions
Copy link

There has been an error during the automated release process. Manual revision is now required.
Please check the related action_run#3081729324 for more information.

@github-actions
Copy link

There has been an error during the automated release process. Manual revision is now required.
Please check the related action_run#3081729324 for more information.

@carrodher carrodher requested review from migruiz4 and removed request for carrodher September 19, 2022 11:25
@carrodher carrodher assigned migruiz4 and unassigned carrodher Sep 19, 2022
@github-actions
Copy link

There has been an error during the automated release process. Manual revision is now required.
Please check the related action_run#3081729324 for more information.

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@migruiz4 migruiz4 force-pushed the automated/ghost-19.1.10 branch from 80f5652 to 5fbb037 Compare September 20, 2022 07:38
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@migruiz4
Copy link
Member

The tests were failing because of a Cypress issue, not a Ghost issue: cypress-io/cypress#5830

As mentioned in this comment:

This disabled error happens consistently when the cypress test tries to enter information into an input field after directly unfocusing from an input field that triggers an event once the focus moves on to another field.

Ghost version 5.15.0 matches that description, both the Post and Page title will trigger an event when switching to a different object, and we are typing the article body right after that.

To avoid that issue, I applied the workaround suggested, adding the {force: True} and switched the object from the article itself to its editable div child.

@github-actions
Copy link

There has been an error during the automated release process. Manual revision is now required.
Please check the related action_run#3081729324 for more information.

@migruiz4
Copy link
Member

After fixing the cy.type() issue, a new error came up:

    <testcase name="allows to create a new page" time="0.0000" classname="allows to create a new page">
      <failure message="Timed out retrying after 30000ms: Expected to find content: &apos;Lorem ipsum dolor sit amet-gyhrw&apos; but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 30000ms: Expected to find content: 'Lorem ipsum dolor sit amet-gyhrw' but never did.
    at Context.eval (http://bitnami-ghost.my/__cypress/tests?p=cypress/integration/ghost_spec.js:164:8)]]></failure>
    </testcase>

In this case, it is failing to verify the new page was created.

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@migruiz4 migruiz4 requested review from FraPazGal and removed request for mdhont, migruiz4 and marcosbc September 20, 2022 12:24
@migruiz4
Copy link
Member

@joancafom @FraPazGal @agomezmoron I have implemented some changes to the VIB tests, could you please review them?

Copy link
Contributor

@agomezmoron agomezmoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migruiz4 thanks for your contribution! LGTM!

@migruiz4 migruiz4 merged commit 896435f into master Sep 21, 2022
@migruiz4 migruiz4 deleted the automated/ghost-19.1.10 branch September 21, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants