Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/ghost] cypress: Remove 'wait for save' during post creation test #12609

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

migruiz4
Copy link
Member

Signed-off-by: Miguel Ruiz miruiz@vmware.com

Description of the change

The changes introduced in #12478 are not enough for the tests to pass consistently.

Although the tests passed in the PR, during most executions the tests are failing because the Ghost post creation fails to wait for the 'Draft - Saved' status twice.

The timeout deadline is probably being exceeded because the post contains an image and the server size is not big enough to complete the test in under 60seconds.
For reference, the 'create-page' test takes about 27 seconds and does not include an image.

Unlike the 'create-page' test, the 'create-post' test won't fail if a wait for 'Draft saved' status is not performed, therefore this PR removes them.
I initially added the wait to be consistent with the 'create-post'.

Benefits

Ghost tests should pass consistently.

Possible drawbacks

Differences between 'create-post' and 'create-page' tests.

Applicable issues

Checklist

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Copy link
Contributor

@agomezmoron agomezmoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Miiguel for simplifying the test!

@migruiz4 migruiz4 merged commit ba7df1b into master Sep 21, 2022
@migruiz4 migruiz4 deleted the ghost-fix-cypress-tests branch September 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants