Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sidecar module #240

Closed
2 tasks done
AMecea opened this issue Feb 25, 2019 · 0 comments · Fixed by #241
Closed
2 tasks done

Refactor sidecar module #240

AMecea opened this issue Feb 25, 2019 · 0 comments · Fixed by #241
Milestone
0.2.6

Comments

@AMecea
Copy link
Contributor

AMecea commented Feb 25, 2019 •
edited
Loading

  • inject only available configs
  • split util module into multiple modules (separation of concerns)
@AMecea AMecea added this to the 0.2.6 milestone Feb 25, 2019
This was referenced Feb 25, 2019
Open
Merged
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this issue Oct 16, 2023
@GuptaManan100 @brandt
Set vttablet init container resource requests and limits (bitpoke#370)
9c0e6a8 
* Set vttablet init container resource requests and limits

Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself.

This fixes the issue reported in bitpoke#212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers.

## History

This is a reimplementation of bitpoke#216 with the change that it no longer sets a default resource _limit_.

This fixes the issue reported in bitpoke#240 and discussed in bitpoke#244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)).

With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit.

fixes bitpoke#212
fixes bitpoke#240

Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com>

* refactor: move defaults to the correct location

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: J. Brandt Buckley <brandt@runlevel1.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.6
Development

Successfully merging a pull request may close this issue.

Refactor sidecar command, add configs bitpoke/mysql-operator
1 participant
@AMecea