-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register MySQL Operator into OperatorHub.io #244
Comments
Depends on #259 and operator-framework/operator-lifecycle-manager#767 . |
Hi @AMecea! I understand that Orchestrator is a stateful component and is primarily the motivation behind making use of the statefulset as the operator deployment methology. Could you give some examples of which statefulset behaviors are key for Orchestrator? Is it possible to decouple the Operator from the Orchestrator and have them communicate through some other method or do they need to live in the same pod? Not super familiar with Orchestrator here, but I am trying to get more information on the statefulset use case here and see if there's a way we can approach it that might resolve the dependency on operator-framework/operator-lifecycle-manager#767 in the meantime. |
…itpoke#244) This reverts commit be42288.
* Set vttablet init container resource requests and limits Sets the resource requirements on each of the default vttablet init containers to the same request and limit values as the vttablet container itself. This fixes the issue reported in bitpoke#212 where pods would fail to be created on clusters with strict quota requirements because no limit was set on the init containers. ## History This is a reimplementation of bitpoke#216 with the change that it no longer sets a default resource _limit_. This fixes the issue reported in bitpoke#240 and discussed in bitpoke#244 where the vttablet pod would fail to be created when the user sets a request larger than the default limit without also setting a larger limit. The user's nil limit would not override the default value because `update.ResourceRequirements(dst, src)` won't update `dst` with a nil `src` ([for good reasons](https://github.com/planetscale/vitess-operator/blob/da7efd4c945193864f5996cb793055449c4de97a/pkg/operator/update/podspec.go#L201-L203)). With this change, users can once again increase the request by itself. If a cluster requires a limit, the user will already need to have set it on for vttablet so we can use the same value to override the init containers' default nil limit. fixes bitpoke#212 fixes bitpoke#240 Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com> * refactor: move defaults to the correct location Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: J. Brandt Buckley <brandt@runlevel1.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: J. Brandt Buckley <brandt@runlevel1.com>
https://www.operatorhub.io/contribute
The text was updated successfully, but these errors were encountered: