-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubycommand #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
reviewed
Sep 24, 2021
ruby/command.go
Outdated
return slice | ||
} | ||
|
||
func sudoNeeded(installType InstallType, slice ...string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would use a more descriptive arg name than slice
, something like command
ofalvai
previously approved these changes
Sep 24, 2021
ofalvai
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Context
This PR finishes the previous go-utils package update in the
command/rubycommand
package and in thecommand/gems/bundler.go
file.The previous migration introduced a global
temporaryFactory
, which blocks us in the generatedcommand.Command
customization (settingcommand.Opts
for specifying work dir for example).An example of how to adopt these changes: bitrise-steplib/steps-fastlane#84.
To finalize this PR a related go-utils PR needs to be merged and go-utils dependency needs to be updated here.
Changes
Introduce
ruby.CommandFactory
interface and implementingcommandFactory
struct for creating ruby related commands.CommandFactory.Create
replaces the previousrubycommand.NewWithParams
,rubycommand.NewFromSlice
andrubycommand.New
functions.CreateBundleExec
replaces the previousgems.BundleExecPrefix
functionality.CreateBundleInstall
replaces the previousgems.BundleInstallCommand
function.CreateGemInstall
replaces the previousrubycommand.GemInstall
function.CreateGemUpdate
replaces the previousrubycommand.GemUpdate
function.Introduce
ruby.Environment
interface and implementingenvironment
struct.RubyInstallType
replaces the previousrubycommand.RubyInstallType
function.IsGemInstalled
replaces the previousrubycommand. IsGemInstalled
function.IsSpecifiedRbenvRubyInstalled
replaces the previousrubycommand. IsSpecifiedRbenvRubyInstalled
function.gems.InstallBundlerCommand
removed in favor of:gems.RbenvVersionsCommand
removed in favor of:ruby.CommandFactory
andruby.Environment
.Investigation details
Decisions