Skip to content

Command locator #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2021
Merged

Command locator #144

merged 2 commits into from
Sep 24, 2021

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Sep 24, 2021

Checklist

Context

Introduce env.CommandLocator interface to wrap exec.LookPath.

Changes

  • Create env.CommandLocator interface and implementing env.commandLocator struct
  • Generate mocks for env.CommandLocator

Investigation details

Decisions

CommandLocator added to the env package as it searches for an executable named file in the directories named by the PATH environment variable.

@godrei godrei mentioned this pull request Sep 24, 2021
Merged
1 task
@godrei godrei merged commit 3e7a04d into master Sep 24, 2021
@godrei godrei deleted the command-locator branch September 24, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofalvai ofalvai ofalvai approved these changes

+1 more reviewer

@Bence1001 Bence1001 Bence1001 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godrei @ofalvai @Bence1001