Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to hardfork #1577

Merged
merged 144 commits into from
Feb 14, 2019
Merged

Merge develop to hardfork #1577

merged 144 commits into from
Feb 14, 2019

Conversation

abitmore
Copy link
Member

No description provided.

oxarbitrage and others added 30 commits August 22, 2018 13:26
As far as I can tell, there was no way previously for an application
to register a plugin and ensure that plugin got loaded -- it would
be necessary to manually edit the config and specify the plugin be
loaded.

This is suboptimal; if third party code wishes to track third party
extensions on the blockchain, the correct way to do this is with a
plugin, and this third party build should be able to load these
required plugins regardless of whether the config lists them or not.

This commit adds a boolean parameter to application::register_plugin
which defaults to false for backwards compatibility; however, if
set to true, the plugin will automatically be enabled when the app
initializes.
That code was nasty and... kinda wrong. So fix it up all shiny-like.

But I also removed the super annoying default "wanted" plugins list,
which only causes problems for third parties like me, and in general is
just poor form. In my opinion, 5220425
provides a much cleaner way to do this, in a way that is friendly rather
than hostile to third parties.

Would Be Nice: A generalized plugin conflict system added at the
abstract_plugin level, so, for example, the elasticsearch plugin can
conflict account_history and we deal with this in a general fashion
rather than having this dirty special case check here.
oxarbitrage
oxarbitrage previously approved these changes Feb 12, 2019
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, thanks!

oxarbitrage
oxarbitrage previously approved these changes Feb 12, 2019
@oxarbitrage
Copy link
Member

I am not totally sure but maybe we should bring the last develop here with the get_ticker fix before more stuff gets merged into develop?

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@abitmore abitmore merged commit 085dc1a into hardfork Feb 14, 2019
@abitmore abitmore deleted the develop-to-hardfork branch February 14, 2019 16:51
@abitmore abitmore changed the title Develop to hardfork Merge develop to hardfork Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants