Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect sign on log message #1595

Merged
merged 1 commit into from
Feb 16, 2019
Merged

incorrect sign on log message #1595

merged 1 commit into from
Feb 16, 2019

Conversation

jmjatlanta
Copy link
Contributor

Attempted to log a message when supply exceeds MAX_SUPPLY, but got the signs crossed. This fixes the issue.

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. make sense following the comments at:

/***
* We have softfork code already in production to prevent exceeding MAX_SUPPLY between 2018-12-21 until HF 1465.
* But we must allow this in replays until 2018-12-21. The HF 1465 code will correct the problem.
* After HF 1465, we MAY be able to remove the cleanup code IF it never executes. We MAY be able to clean
* up the softfork code IF it never executes. We MAY be able to turn the hardfork code into regular code IF
* noone ever attempted this before HF 1465.

I was seeing some of this incorrect logs when doing some testing of #1594 , this pull is fixing the issue.

@abitmore abitmore merged commit a9115fb into hardfork Feb 16, 2019
@abitmore abitmore deleted the jmj_logfix branch February 16, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants