-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compile time #1768
Improve compile time #1768
Conversation
nice! is the 40% build time reduction only in windows or all ? |
Measured on my linux desktop. Don't have a windows machine to test with. |
@cwyyprog try this? |
275e5bf
to
d1de4e2
Compare
d1de4e2
to
edbb245
Compare
The fc bump includes the fix for #1688 |
I made a test and i was not able to get a 40% faster build in Ubuntu 18.04 but just a 15% . develop branch:
pull request:
Also, did you made snapshots of the 2 at block 32M. I think it might worth it. |
Snapshot comparison at 37.9M blocks produced empty diff. |
6dfff17
to
c657635
Compare
c657635
to
285d64d
Compare
Fixes #1738 (hopefully)
The idea is to explicitly specialize certain templates (mostly exceptions, APIs and serialization) in
.cpp
files and declare themextern
in.hpp
files. This avoids them being instantiated (and thus compiled) separately whereever they are used.The result is almost 40% faster build with a significant reduction of required RAM and diskspace. The effect on replay time seems to be lower than the error from measuring.
Measurements:
-j 2
)Note: Requires changes in
fc
as well - bitshares/bitshares-fc#133