Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GRPH 92] Build optimization #137

Merged
merged 7 commits into from
Dec 3, 2019
Merged

[GRPH 92] Build optimization #137

merged 7 commits into from
Dec 3, 2019

Conversation

gladcow
Copy link

@gladcow gladcow commented Sep 20, 2019 •
edited
Loading

Backport of the bitshares/bitshares-core#1768

The idea is to explicitly specialize certain templates (mostly exceptions, APIs and serialization) in .cpp files and declare them extern in .hpp files. This avoids them being instantiated (and thus compiled) separately whereever they are used.

QA notes: this pull request doesn't change the code behavior, so all tests should pass as before.

@gladcow gladcow mentioned this pull request Sep 20, 2019
Open
@gladcow gladcow requested a review from pbattu123 September 20, 2019 11:16
@oxarbitrage
Copy link

Any upgrades on this one ? If applied correctly it is a great improvement in the build time.

@oxarbitrage
Copy link

Another good one that we could consider as optimization to do in the future is IMO bitshares/bitshares-core#1737

@gladcow
Copy link
Author

gladcow commented Nov 15, 2019

I need to update this PR to the actual develop state, so now it is Work-In-Progress

@gladcow gladcow changed the title [GRPH 92] Build optimization [WIP][GRPH 92] Build optimization Nov 15, 2019
@gladcow gladcow changed the title [WIP][GRPH 92] Build optimization [GRPH 92] Build optimization Nov 29, 2019
@gladcow gladcow marked this pull request as ready for review November 29, 2019 12:19
@bobinson bobinson added this to the GPOS-hardfork milestone Nov 29, 2019
@oxarbitrage
Copy link

Getting build error with the last version, please check:

https://github.com/oxarbitrage/logs/blob/master/peerplays_pull137_build.txt

@gladcow
Copy link
Author

gladcow commented Dec 2, 2019

@oxarbitrage , I've fixed the issue, re-review, please

@oxarbitrage oxarbitrage merged commit 3a2def7 into develop Dec 3, 2019
@pbattu123 pbattu123 mentioned this pull request Dec 17, 2019
Closed
@bobinson bobinson mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@pbattu123 pbattu123 Awaiting requested review from pbattu123

@bobinson bobinson Awaiting requested review from bobinson

Assignees

@gladcow gladcow

Labels
None yet
Projects
None yet
Milestone
GPOS-hardfork
Development

Successfully merging this pull request may close these issues.
4 participants
@gladcow @oxarbitrage @bobinson @pmconrad