-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 727b - A second option #33
Conversation
Skip editline when building in MSVC
Remove -std=c++14 flag from CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better than #23 IMO.
Question: is it important for us to have stacktraces for pre-1.65 boost?
I think it isn't, and therefore I'd propose to not copy the old boost code but instead rebase on #36 and detect boost version at compile-time and replace the stacktrace stuff with NOPs if boost is too old.
I agree. If everyone else does, I'll rebase on the Boost 1.66 stuff and a skip the stacktrace logic pre boost 1.65. |
I agree. |
The rebase included commits that muddy the waters. I have created a new PR. |
This is another option for adding stacktrace to bitshares. Instead of porting fc/stacktrace from steem, I pulled stacktrace from the 1.65 version of boost.
Boost has more lines of code, but code quality appears better, and is probably tested to a higher degree (more eyes on it).