[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) #4809

titanism · 2023-02-21T00:10:06Z

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Added new forwarder Forward Email ("FE"). Forward Email is 100% open-source on GitHub at https://github.com/forwardemail. Per email communication with a member of Bitwarden, we submitted this PR to save you time. Our users would love to be able to use FE through Bitwarden. Let us know if you have any questions! 🎉

Code changes

apps/browser/src/popup/generator/generator.component.html: Added FE to browser generator.
apps/desktop/src/app/vault/generator.component.html: Added FE to desktop generator.
apps/web/src/app/tools/generator.component.html: Added FE to web generator.
apps/web/webpack.config.js: Added FE to Content-Security-Policy ("CSP") - note that we had to add the domain at the root level similarly to Fastmail since our API endpoint has a domain name included in it and is dynamic.
libs/angular/src/components/generator.component.ts: Added FE to Angular generator component.
libs/common/src/email-forwarders/forward-email-forwarder.ts: Added FE forwarder class with API integration (see https://forwardemail.net/api for complete API reference and our GitHub sourcefor source code on the back-end).
libs/common/src/email-forwarders/forwarder-options.ts: Added FE to list of built-in forwarder options.
libs/common/src/services/usernameGeneration.service.ts: Added FE to user generation service (with default of hideaddress.net, which is a vanity domain we provide for free for all users with API keys).

CLAassistant · 2023-02-21T00:10:11Z

All committers have signed the CLA.

bitwarden-bot · 2023-02-21T00:10:27Z

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-1060

…per <bitwarden/clients#4809>)

…den/clients#4809>)

titanism · 2023-02-21T00:35:59Z

This PR is ready and tested on our side. We have also deployed both forwardemail/forwardemail.net@01731e2 and forwardemail/forwardemail.net@2c604c2 to production, which allows this PR's API request approach to work.

…ssed (per <https://github.com/bitwarden/clients/pull/4809\>)

titanism · 2023-02-21T00:58:58Z

Ok, with the last two fixes in forwardemail/forwardemail.net@6f5c12d (deployed to our production servers already) and 39079ed - this PR is now good to go. We fixed the authorization header in this PR specifically in the latter commit mentioned in this comment. Before it was "Authentication" header, but since we use Basic auth, we had to switch it to "Authorization" header with base64 encoded user/pass.

titanism · 2023-02-21T01:04:56Z

Lastly, fcb1bcf fixes the end email generated via API response. We've tested this locally and it works!

PR is now ready for merge 💯 🚀 ✅ Let us know of any issues.

…in does not exist on your account." (automatically localized with i18n for user)

titanism · 2023-03-03T20:45:36Z

This PR is ready to go!!! ✅ We fixed the base64 encoding.

titanism · 2023-03-03T20:51:02Z

See related discussion here https://github.com/orgs/bitwarden/discussions/4924

djsmith85 · 2023-03-13T10:41:31Z

Hi @titanism and thank you for your contribution,

We are in the process of moving some files around in preparation for code-ownership. With that, some conflicts have shown up here. It should be fairly easy to resolve them, though.

Just also wanted to point out the work being done with #4963, which will also need to be incorporated here, once merged.

Kind regards,
Daniel

dwbit · 2023-04-03T17:02:01Z

@titanism just wanted to make sure you had a chance to review @djsmith85's comments above?

…per <bitwarden/clients#4809>)

…den/clients#4809>)

…ssed (per <https://github.com/bitwarden/clients/pull/4809\>)

djsmith85 · 2023-05-25T10:49:02Z

@titanism: I was looking into merging master and fixing any merge conflicts. Unfortunately I do not have permission to push these changes back onto your branch (master), so I cannot update this PR.

Could you please move your changes onto a new branch, where I have permission to push onto, in case any changes need to be made by me.

If this means creating a new PR, please mention me and link to this PR.

Kind regards,
Daniel

titanism · 2023-05-25T17:20:27Z

@djsmith85 done! see your inbox and you should have collab access at https://github.com/forwardemail/clients.

titanism · 2023-05-25T19:27:26Z

Thank you @djsmith85 – also an exciting announcement: our team launched outbound SMTP support over the weekend!

titanism · 2023-06-05T21:23:41Z

@djsmith85 if you or anyone else @bitwarden need a test account or want to try us out - just create an account for free at https://forwardemail.net and then send an email support@forwardemail.net and we'll hook you up with a year or more of free credit 🙏 🙇

djsmith85

@titanism Thanks again for your contribution.

The changes are looking good, and only needed some minor tweaks.

I have reviewed and verified the changes locally and these are now ready to get passed on to QA for testing.

Thank you for offering support with test accounts, I'm sure we'll be in touch

djsmith85 · 2023-06-09T07:55:05Z

@titanism QA have given their approval and your changes are ready to get merged. They will be included in the 2023.6 release.

Thanks again for your contribution!

titanism · 2023-06-09T18:54:19Z

Thank you! 🙏 👏

titanism · 2023-07-03T18:58:47Z

@djsmith85 Hi there 👋 just curious when this will get released? Is 6.0.0 coming out soon?

withinfocus · 2023-07-03T19:00:22Z

@titanism 👋 -- our next server release, 2023.7, is intended to be released next week.

Woodham · 2023-09-10T17:51:29Z

libs/common/src/tools/generator/username/email-forwarders/forward-email-forwarder.ts

+    };
+    const url = `https://api.forwardemail.net/v1/domains/${options.forwardemail.domain}/aliases`;
+    requestInit.body = JSON.stringify({
+      labels: options.website,


Hi - I noticed this option appear the other day and tried to use it for the first time today - unfortunately I hit a bit of an issue.

It seems like it doesn't work if the website URL is too long - it fails with the error:

Forward Email error: Labels.0 is longer than the maximum allowed length (20).

I noticed that Alias labels on Forwardemail are restricted to length 20, and a quick look at this PR shows that it looks like it's trying to add the website url as a a label on this line.

This means website URLs longer than 20 characters will fail to generate a name.

Fixed and deployed @Woodham – try again, it should work! Thanks for reporting the issue 🙏

Ref: forwardemail/forwardemail.net@6c051dd

…clients/pull/4809\#discussion_r1320837175>

Added new forwarder (Forward Email <https://forwardemail.net>)

f8c1075

bitwarden-bot changed the title ~~Added new forwarder (Forward Email <https://forwardemail.net>)~~ [PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) Feb 21, 2023

bitwarden-bot added the community-pr label Feb 21, 2023

titanism added a commit to forwardemail/forwardemail.net that referenced this pull request Feb 21, 2023

feat: support blank or missing name on API request (generates random …

01731e2

…per <bitwarden/clients#4809>)

titanism added a commit to forwardemail/forwardemail.net that referenced this pull request Feb 21, 2023

feat: support blank or missing recipients on API request (per <bitwar…

2c604c2

…den/clients#4809>)

titanism referenced this pull request in forwardemail/forwardemail.net Feb 21, 2023

feat: enable aliases by default on creation even if is_enabled not pa…

6f5c12d

…ssed (per <https://github.com/bitwarden/clients/pull/4809\>)

fix: fixed Basic authorization header

39079ed

fix: fixed returned email value

fcb1bcf

titanism added 5 commits February 20, 2023 19:55

feat: added verbose message for end-users (e.g. "Not Found" vs. "Doma…

a858960

…in does not exist on your account." (automatically localized with i18n for user)

Merge branch 'master' into master

8dcef47

Merge branch 'master' into master

45cb5df

fix: fixed Buffer.from to Utils.fromBufferToB64

df3f635

fix: fixed fromBufferToB64 to fromUtf8ToB64

18e481a

Merge branch 'master' into master

94c6cee

titanism added a commit to forwardemail/forwardemail.net that referenced this pull request May 21, 2023

feat: support blank or missing name on API request (generates random …

e46dcc2

…per <bitwarden/clients#4809>)

titanism added a commit to forwardemail/forwardemail.net that referenced this pull request May 21, 2023

feat: support blank or missing recipients on API request (per <bitwar…

9eb5f6a

…den/clients#4809>)

titanism referenced this pull request in forwardemail/forwardemail.net May 21, 2023

feat: enable aliases by default on creation even if is_enabled not pa…

bbd5857

…ssed (per <https://github.com/bitwarden/clients/pull/4809\>)

djsmith85 self-assigned this May 25, 2023

djsmith85 added the needs-changes Closes PR if no further changes after 21 days label May 25, 2023

Merge branch 'master' of https://github.com/bitwarden/clients

6c1807c

djsmith85 requested a review from a team as a code owner May 25, 2023 18:13

djsmith85 removed the needs-changes Closes PR if no further changes after 21 days label May 25, 2023

djsmith85 added 2 commits June 5, 2023 23:19

Remove try-catch to properly display api errors

29aebd6

Merge branch 'master' of https://github.com/bitwarden/clients

1c536bf

djsmith85 mentioned this pull request Jun 5, 2023

[PM-1060] Community/pm 1060 add new forwarder #5568

Closed

djsmith85 approved these changes Jun 5, 2023

View reviewed changes

djsmith85 mentioned this pull request Jun 5, 2023

[PM-2522] Simplelogin: Fix display of api-error messages #5570

Merged

djsmith85 added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels Jun 6, 2023

djsmith85 merged commit d18b45a into bitwarden:master Jun 9, 2023

djsmith85 mentioned this pull request Jun 9, 2023

Fix broken import of misc/utils #5586

Merged

titanism mentioned this pull request Jun 19, 2023

Forward Email not included privacyguides/privacyguides.org#2206

Closed

2 tasks

Woodham reviewed Sep 10, 2023

View reviewed changes

titanism referenced this pull request in forwardemail/forwardemail.net Sep 10, 2023

fix: increased maxlength of labels per <https://github.com/bitwarden/…

6c051dd

…clients/pull/4809\#discussion_r1320837175>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) #4809

[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) #4809

titanism commented Feb 21, 2023

CLAassistant commented Feb 21, 2023 •

edited

Loading

bitwarden-bot commented Feb 21, 2023

titanism commented Feb 21, 2023

titanism commented Feb 21, 2023 •

edited

Loading

titanism commented Feb 21, 2023

titanism commented Mar 3, 2023

titanism commented Mar 3, 2023

djsmith85 commented Mar 13, 2023

dwbit commented Apr 3, 2023

djsmith85 commented May 25, 2023

titanism commented May 25, 2023

titanism commented May 25, 2023

titanism commented Jun 5, 2023

djsmith85 left a comment

djsmith85 commented Jun 9, 2023

titanism commented Jun 9, 2023

titanism commented Jul 3, 2023

withinfocus commented Jul 3, 2023

Woodham Sep 10, 2023

titanism Sep 10, 2023

[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) #4809

[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) #4809

Conversation

titanism commented Feb 21, 2023

Type of change

Objective

Code changes

CLAassistant commented Feb 21, 2023 • edited Loading

bitwarden-bot commented Feb 21, 2023

titanism commented Feb 21, 2023

titanism commented Feb 21, 2023 • edited Loading

titanism commented Feb 21, 2023

titanism commented Mar 3, 2023

titanism commented Mar 3, 2023

djsmith85 commented Mar 13, 2023

dwbit commented Apr 3, 2023

djsmith85 commented May 25, 2023

titanism commented May 25, 2023

titanism commented May 25, 2023

titanism commented Jun 5, 2023

djsmith85 left a comment

Choose a reason for hiding this comment

djsmith85 commented Jun 9, 2023

titanism commented Jun 9, 2023

titanism commented Jul 3, 2023

withinfocus commented Jul 3, 2023

Woodham Sep 10, 2023

Choose a reason for hiding this comment

titanism Sep 10, 2023

Choose a reason for hiding this comment

CLAassistant commented Feb 21, 2023 •

edited

Loading

titanism commented Feb 21, 2023 •

edited

Loading