Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-129] Refactor email forwarding providers to remove filtering for self-hosted #4963

Merged
merged 6 commits into from
Mar 13, 2023

Conversation

gbubemismith
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Modify

This PR updates the Generator Component in apps/web/src/app/tools/generator.component.ts to use a new EmailForwarder model that includes a validForSelfHosted property. This property filters email forwarders based on whether they are valid for self-hosted instances.

Code changes

  • libs/common/src/models/domain/email-forwarder-options.ts: Created a EmailForwarderOptions model to include properties that can be used to filter email forwarders.
  • libs/angular/src/components/generator.component.ts Updated the forwardOptions variable to use the EmailForwarderOptions model and introduced the validForSelfHosted which can be used to filter the email forwarders.
  • apps/web/src/app/tools/generator.component.ts Filtered the forwardOptions list based to allow email forwarders valid for self-hosted instances.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@gbubemismith gbubemismith added the needs-qa Marks a PR as requiring QA approval label Mar 8, 2023
@gbubemismith gbubemismith requested a review from a team March 8, 2023 23:38
differsthecat
differsthecat previously approved these changes Mar 9, 2023
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@gbubemismith gbubemismith removed the needs-qa Marks a PR as requiring QA approval label Mar 10, 2023
@gbubemismith gbubemismith merged commit 1666488 into master Mar 13, 2023
@gbubemismith gbubemismith deleted the PM-129 branch March 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants