Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-265] CL/extension refresh feature branch #8696

Draft
wants to merge 160 commits into
base: main
Choose a base branch
from
Draft

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Apr 11, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The feature branch will contain all of the style updates to existing components, as well as changes to colors, fonts, and other low level primitives. New components will be merged into main to unblock other teams, but they should only be used behind a feature flag.

Unless otherwise noted, all commits have already been reviewed in a separate PR.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

See Storybook.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 36.47799% with 101 lines in your changes missing coverage. Please review.

Project coverage is 33.59%. Comparing base (e8dac0c) to head (5bebba3).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...bs/components/src/form-field/form-field.stories.ts 0.00% 14 Missing ⚠️
.../components/src/form-field/form-field.component.ts 58.33% 2 Missing and 8 partials ⚠️
libs/components/src/checkbox/checkbox.stories.ts 0.00% 9 Missing ⚠️
...omponents/src/chip-select/chip-select.component.ts 0.00% 8 Missing ⚠️
libs/components/src/input/input.directive.ts 58.33% 4 Missing and 1 partial ⚠️
libs/components/src/item/item-content.component.ts 0.00% 5 Missing ⚠️
libs/components/src/form-field/prefix.directive.ts 20.00% 4 Missing ⚠️
...omponents/src/toggle-group/toggle-group.stories.ts 0.00% 4 Missing ⚠️
libs/components/src/banner/banner.component.ts 25.00% 3 Missing ⚠️
...log/simple-dialog/simple-dialog.service.stories.ts 0.00% 3 Missing ⚠️
... and 23 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8696   +/-   ##
=======================================
  Coverage   33.58%   33.59%           
=======================================
  Files        2829     2829           
  Lines       88310    88381   +71     
  Branches    16835    16844    +9     
=======================================
+ Hits        29658    29688   +30     
- Misses      56329    56364   +35     
- Partials     2323     2329    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Logo
Checkmarx One – Scan Summary & Details4e2a3cc7-eaa4-4b15-8caf-62b76f902c4f

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 228 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members.component.html: 55
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members-uri.component.html: 35
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health-members-uri.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/risk-insights/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3

@willmartian willmartian self-assigned this Apr 15, 2024
@willmartian willmartian changed the title CL Extension refresh feature branch [CL-265] CL extension refresh feature branch Apr 16, 2024
@willmartian willmartian changed the title [CL-265] CL extension refresh feature branch [CL-265] CL/extension refresh feature branch May 6, 2024
@willmartian willmartian requested review from a team and willmartian July 2, 2024 20:30
* update callout styles; make component standalone

* add import block to mdx page
@willmartian willmartian added the hold do not merge, do not approve yet label Oct 21, 2024
@willmartian
Copy link
Contributor

Hold until beta version is reverted: 1666f6b

vleague2 and others added 27 commits October 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants