Ensure safari extension is included in mas and not only darwin

[Hinton]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

The upgrade of electron builder in #1088 changed how we include and sign the safari extension. Unfortunately when building for the mac app store the electronPlatformName is not darwin but mas. This resulted in the extension not being included in the desktop release.

I needed to also change from signApp to sign since we need to sign a MAS application, which required me to replicate some of the logic used to build the arguments.

Code changes

• scripts/after-sign.js: Ensure mas runs the specific copy and re-sign of the safari extension.

Testing requirements

Verify the GH release pipeline contains the safari.appex in PlugIn directory.

Before you submit

• I have checked for linting errors (npm run lint) (required)
• This change requires a documentation update (notify the documentation team)
• This change has particular deployment requirements (notify the DevOps team)

[Hinton]

CI build is failing, we'll need to replace signApp with sign and re-build some of the arguments to match what https://github.com/electron-userland/electron-builder/blob/fce1a1fab66e3f5cd741a4cecc4af8377aea9dd8/packages/app-builder-lib/src/macPackager.ts#L170-L172 produces

[sschwetz]

Once the notarization by apple is successful how long will the wait be for it to appear in the store?

[MGibson1]

I wish we could get away from doing this.

Side note that doesn't need to be acted on here, the afterSign key can be applied to only mac builds in package.json so we don't need to worry about identifying whether it's a mac build

[jslopezgithub]

I downloaded 1.29.1 and I'm still seeing the same issue. I ran lsregister and rebooted and it did not make a difference.
MacOS 11.6.1 (20G224) / Safari 15.1

[kspearrin]

@jslopezgithub 1.29.1 isn't available on the mac app store yet. It is pending review from Apple.

[jslopezgithub]

@kspearrin It is available in the releases: https://github.com/bitwarden/desktop/releases/download/v1.29.1/Bitwarden-1.29.1.dmg

[kspearrin]

@jslopezgithub The extension is only available on the Mac App Store version.

[andrewkr]

If I've correctly read what's above, 1.29.1 from the Mac App Store ( first screenshot) should contain the fix for the missing extension.

That's what I've downloaded this afternoon, but as my second screenshot shows, it isn't there.

What am I missing? (Yes, apart from the extension.)

[djsmith85]

Hi @andrewkr sorry for the inconvenience, please have a look at https://community.bitwarden.com/t/bitwarden-does-not-show-as-safari-extension-macos/28229/32

[andrewkr]

Hi @andrewkr sorry for the inconvenience, please have a look at https://community.bitwarden.com/t/bitwarden-does-not-show-as-safari-extension-macos/28229/32

Thanks!

It took a few tries, but I got there in the end.