-
Notifications
You must be signed in to change notification settings - Fork 20
Auth/PM-22661 - Send Access #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…el + send access token struct
New Issues (3)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 76.65% 78.14% +1.48%
==========================================
Files 266 274 +8
Lines 24705 27185 +2480
==========================================
+ Hits 18937 21243 +2306
- Misses 5768 5942 +174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… locations to be more idiomatic and logical
…flat structures and test utilities wiremock and zeroize.
…ng C dynamic lib, build a normal rust lib (rlib) for this crate since a C dynamic lib can't be used to run E2E tests.
…ion tests can only access the public API
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
855b744
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more visibility changes but looks great otherwise. Thanks for iterating on this.
crates/bitwarden-auth/src/send_access/api/token_api_success_response.rs
Outdated
Show resolved
Hide resolved
crates/bitwarden-auth/src/send_access/api/token_request_payload.rs
Outdated
Show resolved
Hide resolved
crates/bitwarden-auth/src/send_access/api/token_request_payload.rs
Outdated
Show resolved
Hide resolved
crates/bitwarden-auth/src/send_access/api/token_request_payload.rs
Outdated
Show resolved
Hide resolved
…_success_response.rs Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22661
See clients PR: bitwarden/clients#16007
📔 Objective
To build out the SDK portion of the new
Auth/SendAccess
feature which serves outSendAccessTokens
for successful authN requests.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes