Skip to content

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Jul 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22661
See clients PR: bitwarden/clients#16007

📔 Objective

To build out the SDK portion of the new Auth/SendAccess feature which serves out SendAccessTokens for successful authN requests.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 17, 2025

Logo
Checkmarx One – Scan Summary & Details63d18845-647c-44ea-9415-039d26c81ac5

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-7783 Npm-form-data-4.0.3
detailsRecommended version: 4.0.4
Description: Use of Insufficiently Random Values vulnerability in form-data allows HTTP Parameter Pollution (HPP). This vulnerability is associated with program...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: Sl%2FDjJHdQPvAhgTccGepYhIgX4UBQUDyDi6Hi8gnJQw%3D
Vulnerable Package
CRITICAL CVE-2025-7783 Npm-axios-1.9.0
detailsRecommended version: 1.12.0
Description: Use of Insufficiently Random Values vulnerability in form-data allows HTTP Parameter Pollution (HPP). This vulnerability is associated with program...
Attack Vector: NETWORK
Attack Complexity: HIGH

ID: WhOJ92GNbszCmMexTv30hIbeeDU0V14wUl3TS%2BRTKFQ%3D
Vulnerable Package
LOW CVE-2025-54798 Npm-tmp-0.0.33
detailsRecommended version: 0.2.4
Description: tmp is a temporary file and directory creator for node.js. In versions prior to 0.2.4, tmp is vulnerable to an arbitrary temporary file "/" directo...
Attack Vector: LOCAL
Attack Complexity: HIGH

ID: pku3WtsT8bnLaD0j7%2FFsuD02ySFLowbHbl%2Ba43nwZus%3D
Vulnerable Package

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 96.70193% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.14%. Comparing base (2e7f960) to head (21a2a48).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...th/src/send_access/api/token_api_error_response.rs 93.01% 43 Missing ⚠️
...arden-auth/src/send_access/access_token_request.rs 96.35% 5 Missing ⚠️
...rden-auth/src/send_access/access_token_response.rs 75.00% 4 Missing ⚠️
crates/bitwarden-auth/src/send_access/client.rs 99.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   76.65%   78.14%   +1.48%     
==========================================
  Files         266      274       +8     
  Lines       24705    27185    +2480     
==========================================
+ Hits        18937    21243    +2306     
- Misses       5768     5942     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…flat structures and test utilities wiremock and zeroize.
…ng C dynamic lib, build a normal rust lib (rlib) for this crate since a C dynamic lib can't be used to run E2E tests.
dani-garcia
dani-garcia previously approved these changes Sep 12, 2025
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Hinton
Hinton previously approved these changes Sep 16, 2025
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more visibility changes but looks great otherwise. Thanks for iterating on this.

…_success_response.rs

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
…uest_payload.rs

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Copy link

@JaredSnider-Bitwarden JaredSnider-Bitwarden merged commit 9b1253a into main Sep 16, 2025
50 checks passed
@JaredSnider-Bitwarden JaredSnider-Bitwarden deleted the auth/pm-22661/send-access branch September 16, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants