Skip to content

Update SDK to 1.0.0-3101-0eba924a #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2025
Merged

Update SDK to 1.0.0-3101-0eba924a #5893

merged 5 commits into from
Sep 19, 2025
+37 −5

Conversation

bw-ghapp[bot]
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Sep 16, 2025 •
edited by atlassian bot
Loading

Updates the SDK version from 1.0.0-3005-5a722fd2 to com.bitwarden:sdk-android 1.0.0-3101-0eba924a

What's Changed

Raw changelog 
- [PM-23193] Add ArchivedDate (#422)
- [deps]: Update @openapitools/openapi-generator-cli to v2.23.1 (#387)
- Add dylint lints for errors (#430)
- Migrate more b64 (#411)
- Remove unused vault locked error (#440)
- Rename Error variants (#456)
- feat(SendAccess): [Auth/PM-22661] Send Access (#351)
- [PM-20288] Automate iOS repo update and improve release-swift process (#439)
- [PM-24683] Add updateKdf function (#383)
- [PM-22589] Implement basic db migrations for indexeddb (#410)
- [PM-20288] Fix GitHub Release creation in sdk-swift repo (#459)

@bw-ghapp bw-ghapp bot requested a review from brian-livefront as a code owner September 16, 2025 18:57
@bw-ghapp bw-ghapp bot added the automated-pr PR created by workflow or other automation label Sep 16, 2025
@bw-ghapp bw-ghapp bot requested a review from david-livefront as a code owner September 16, 2025 18:57
@bw-ghapp bw-ghapp bot added the t:ci Updates to automated workflows label Sep 16, 2025
@bw-ghapp bw-ghapp bot requested a review from a team as a code owner September 16, 2025 18:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 46382da6-a1ff-4275-95aa-69da040884fa

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Use_of_Hardcoded_Password /app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt: 2376

@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3085-745287fd Update SDK to 1.0.0-3095-0f493c24 Sep 17, 2025
@bw-ghapp bw-ghapp bot changed the title Update SDK to 1.0.0-3095-0f493c24 Update SDK to 1.0.0-3101-0eba924a Sep 17, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.24%. Comparing base (8de4653) to head (2e38dd0).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
.../vault/repository/util/VaultSdkCipherExtensions.kt 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5893      +/-   ##
==========================================
+ Coverage   84.23%   84.24%   +0.01%     
==========================================
  Files         707      709       +2     
  Lines       53351    53479     +128     
  Branches     7348     7362      +14     
==========================================
+ Hits        44938    45056     +118     
- Misses       5821     5830       +9     
- Partials     2592     2593       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

david-livefront
david-livefront reviewed Sep 18, 2025
View reviewed changes
app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt
shouldViewPassword = viewPassword,
key = key,
encryptedFor = encryptedFor,
archivedDate = archivedDate?.let { ZonedDateTime.ofInstant(it, ZoneOffset.UTC) },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is intended to be UTC?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-livefront I matched what we already have for deletedDate . Is there a way to confirm this? Should I ask the sdk team?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does not matter, I'm just not a fan of using ZonedDateTimes 😄. I prefer Instants

@LRNcardozoWDF LRNcardozoWDF added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit 6f6aaca Sep 19, 2025
9 checks passed
@LRNcardozoWDF LRNcardozoWDF deleted the sdlc/sdk-update branch September 19, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LRNcardozoWDF LRNcardozoWDF LRNcardozoWDF left review comments

@SaintPatrck SaintPatrck SaintPatrck approved these changes

@david-livefront david-livefront david-livefront approved these changes

@brian-livefront brian-livefront Awaiting requested review from brian-livefront brian-livefront is a code owner

Assignees
No one assigned
Labels
automated-pr PR created by workflow or other automation t:ci Updates to automated workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaintPatrck @LRNcardozoWDF @david-livefront