Rename Error variants

[dani-garcia]

🎟️ Tracking

📔 Objective

Remove all the error suffixes from the error variants. This will be linted against by #430 in CI in the future.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 5b94e395-baac-4d86-93f2-d61bb089fdcb

Great job! No new security vulnerabilities introduced in this pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Hinton]

Nice

[codecov]

Codecov Report

❌ Patch coverage is 64.15094% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.92%. Comparing base (9ac1d3e) to head (cc44546).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...crypto/src/safe/password_protected_key_envelope.rs	44.44%	10 Missing ⚠️
crates/bitwarden-ipc/src/rpc/exec/handler.rs	0.00%	4 Missing ⚠️
bitwarden_license/bitwarden-sm/src/error.rs	50.00%	1 Missing ⚠️
crates/bitwarden-core/src/key_management/crypto.rs	0.00%	1 Missing ⚠️
crates/bitwarden-ipc/src/ipc_client.rs	0.00%	1 Missing ⚠️
crates/bitwarden-ssh/src/export.rs	83.33%	1 Missing ⚠️
crates/bitwarden-ssh/src/import.rs	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   76.89%   76.92%   +0.02%     
==========================================
  Files         270      270              
  Lines       25592    25582      -10     
==========================================
- Hits        19680    19678       -2     
+ Misses       5912     5904       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.