Skip to content

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 12, 2025

🎟️ Tracking

📔 Objective

We removed the ability to throw VaultLocked a while back. This removes the actual error struct and any place it's used in.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners September 12, 2025 08:52
Copy link
Contributor

github-actions bot commented Sep 12, 2025

Logo
Checkmarx One – Scan Summary & Details394c005d-5659-4672-ad95-0d0592d1ed3c

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.94%. Comparing base (d9ad5e8) to head (9ed085f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   76.93%   76.94%   +0.01%     
==========================================
  Files         270      270              
  Lines       25608    25626      +18     
==========================================
+ Hits        19702    19719      +17     
- Misses       5906     5907       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton requested a review from dereknance September 15, 2025 10:32
Copy link

@Hinton Hinton merged commit 9ac1d3e into main Sep 15, 2025
50 checks passed
@Hinton Hinton deleted the remove-vault-locked branch September 15, 2025 15:45
gbubemismith pushed a commit that referenced this pull request Sep 16, 2025
We removed the ability to throw `VaultLocked` a while back. This removes
the actual error struct and any place it's used in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants