Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tidy_schemas() does not handle missing tables #33

Open
bjcairns opened this issue Feb 6, 2021 · 0 comments
Open

.tidy_schemas() does not handle missing tables #33

bjcairns opened this issue Feb 6, 2021 · 0 comments

Comments

@bjcairns
Copy link
Owner

bjcairns commented Feb 6, 2021

Most of the package works just fine with missing or extra tables because the functions generically save or load whatever tables are present.

.tidy_schemas(), however, fixes up specific tables and needs error handling or warning/skipping missing tables which currently it does not have.

Feakster added a commit that referenced this issue Feb 18, 2021
- Changes to facilitate the addition of the 'recordtab' and 'recordcol' schemas [fixes #33].
Feakster added a commit that referenced this issue Feb 25, 2021
- Restructured .tidy_schemas() in to a series of sub-functions, named to indicate the schemas they modify.
- Added extensive schema name-checking throughout all the functions now comprising .tidy_schemas(). Attempts to modify schemas are now only made where those schemas are present [fixes #33].
- Modified the verbosity of .tidy_schemas() and its sub-functions so that statements are only printed where relevant, and so as to only include the names of relevant schemas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant