Work to make .tidy_schemas more flexible and robust to missing schemas #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Feakster
commented
Feb 25, 2021
Feakster
commented
- Restructured .tidy_schemas() in to a series of sub-functions, named to indicate the schemas they modify.
- Added extensive schema name-checking throughout all the functions now comprising .tidy_schemas(). Attempts to modify schemas are now only made where those schemas are present [fixes .tidy_schemas() does not handle missing tables #33].
- Modified the verbosity of .tidy_schemas() and its sub-functions so that statements are only printed where relevant, and so as to only include the names of relevant schemas.
- Restructured .tidy_schemas() in to a series of sub-functions, named to indicate the schemas they modify. - Added extensive schema name-checking throughout all the functions now comprising .tidy_schemas(). Attempts to modify schemas are now only made where those schemas are present [fixes #33]. - Modified the verbosity of .tidy_schemas() and its sub-functions so that statements are only printed where relevant, and so as to only include the names of relevant schemas.
|
Sorry Ben, this is a biggy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.