Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support workspace inheriting #34

Closed
clearloop opened this issue Mar 21, 2023 · 1 comment · Fixed by #39 or paritytech/parity-scale-codec#535
Closed

Does not support workspace inheriting #34

clearloop opened this issue Mar 21, 2023 · 1 comment · Fixed by #39 or paritytech/parity-scale-codec#535

Comments

@clearloop
Copy link

clearloop commented Mar 21, 2023

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

let manifest_dir = env::var("CARGO_MANIFEST_DIR").map_err(|_| Error::CargoManifestDirNotSet)?;

[workspace.dependencies]
foo = { package = "bar" }
[dependencies]
foo = { workspace = true }

only iterated the dependencies inside the package, once a package renamed its dependency in workspace level, the searching logic doesn't work

@pmikolajczyk41
Copy link

Seems like the nasty workaround is to include package attribute, which is ignored by rust compiler (and throws warning), but is taken into consideration by this macro - see: use-ink/ink#1835

bkchr added a commit that referenced this issue Oct 3, 2023
- This pull request fixes workspace inheriting: #34
- Introduces a `rustfmt` check and configuration
- Bumps MSRV to `1.66.0` and introduces a check for it in CI
- Removes `once_cell` as it isn't required anymore
- Bumps all the deps
@bkchr bkchr mentioned this issue Oct 3, 2023
@bkchr bkchr closed this as completed in #39 Oct 3, 2023
toptalhook added a commit to toptalhook/proc-macro-crate that referenced this issue Jun 1, 2024
- This pull request fixes workspace inheriting: bkchr/proc-macro-crate#34
- Introduces a `rustfmt` check and configuration
- Bumps MSRV to `1.66.0` and introduces a check for it in CI
- Removes `once_cell` as it isn't required anymore
- Bumps all the deps
toptalhook added a commit to toptalhook/proc-macro-crate that referenced this issue Jun 1, 2024
- This pull request fixes workspace inheriting: bkchr/proc-macro-crate#34
- Introduces a `rustfmt` check and configuration
- Bumps MSRV to `1.66.0` and introduces a check for it in CI
- Removes `once_cell` as it isn't required anymore
- Bumps all the deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants