-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump proc-macro-crate
to 2.0.0 in borsh-derive
#256
Conversation
@serprex please fix CI. Please also provide a short memo in description, what the advantages for borsh lib of bumping proc-macro-crate from 1 to 2 are. |
I noticed But, you're right & So I've fixed PR with MSRV being raised to 1.67, but understand rejecting this PR since my original assessment didn't involve raising MSRV |
proc-macro-crate
to 2.0.0 in borsh-derive
@frol please take a look. I'll revert second commit if it's ok to bump msrv to 1.67 |
README.md
Outdated
[borsh: rustc 1.66+]: https://img.shields.io/badge/rustc-1.66+-lightgray.svg | ||
[Rust 1.66]: https://blog.rust-lang.org/2022/12/15/Rust-1.66.0.html | ||
[borsh: rustc 1.67+]: https://img.shields.io/badge/rustc-1.67+-lightgray.svg | ||
[Rust 1.67]: https://blog.rust-lang.org/2022/12/15/Rust-1.67.0.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: fix link if the msrv is bumped to 1.67
@dj8yfo Thanks for staying on guard for users of borsh and avoiding raising requirements unnecessarily. This change as of now is totally fine with me. |
Raise MSRV to 1.67
Enables getting latest toml crates in dependencies
Edit: upgrading
proc-macro-crate
is useful with respect to supportingborsh
package rename in workspace levelThis is illustrated by sample repo