Specifying host when listening for WebpackDevServer (#257)

blackbaud · Aug 16, 2017 · da33cdc · da33cdc
1 parent 40a2a94
commit da33cdc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cli/serve.js b/cli/serve.js
@@ -64,7 +64,7 @@ function serve(argv, skyPagesConfig, webpack, WebpackDevServer) {
 
     const compiler = webpack(config);
     const server = new WebpackDevServer(compiler, config.devServer);
-    server.listen(config.devServer.port, (err) => {
+    server.listen(config.devServer.port, 'localhost', (err) => {
       if (err) {
         logger.error(err);
       }

diff --git a/test/cli-serve.spec.js b/test/cli-serve.spec.js
@@ -74,7 +74,7 @@ describe('cli serve', () => {
 
     function webpackDevServer() {
       return {
-        listen: (port, cb) => {
+        listen: (port, host, cb) => {
           cb(err);
           expect(logger.error).toHaveBeenCalledWith(err);
           mock.stop(f);
@@ -98,7 +98,7 @@ describe('cli serve', () => {
 
     function webpackDevServer() {
       return {
-        listen: (port, cb) => {
+        listen: (port, host, cb) => {
           cb();
           expect(logger.error).not.toHaveBeenCalled();
           mock.stop(f);