Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Specifying host when listening for WebpackDevServer #257

Merged
merged 2 commits into from
Aug 16, 2017

Conversation

Blackbaud-BobbyEarl
Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl commented Aug 16, 2017

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #257   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          54     54           
  Lines        1265   1265           
  Branches      190    190           
=====================================
  Hits         1265   1265
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/serve.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a2a94...dfcc490. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Brandon S.'s tests on Windows passed, I was also able to run two SPA's on my Mac.

@Blackbaud-BobbyEarl
Copy link
Author

Blackbaud-BobbyEarl commented Aug 16, 2017

They did pass, as did my local testing on a Windows VM. Windows was the only affected system.

Ultimately, I believe http-party/node-portfinder#39 is the problem, but explicitly passing localhost into webpack-dev-server resolves it (they use portfinder under the hood too).

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl merged commit da33cdc into master Aug 16, 2017
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the serve-localhost branch August 16, 2017 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants