This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Updates to support Windows #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 47 47
Lines 1110 1110
Branches 157 157
=====================================
Hits 1110 1110
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
requested review from
blackbaud-brandonstirnaman and
Blackbaud-PaulCrowder
* Updated dependencies * Updated skyux2 version * Updated dependencies * Using template branch for testing * Reverted protractor config * Pointing to dev branch for local testing * Updated package json * Using explicit types * Updated version of skyux * Updated dependencies * Fixed linting errors * Added fontfaceobserver to types * Fixed tslint errors * Fixed tslint errors * Ensure that the files are not directories * Update tests for file processor * Update plugin-file-processor.js * Update plugin-file-processor.spec.js * Updated version of skyux * Updated config * Added specific version of firefox * Updated tsconfig * Updating travis version * Updated version of firefox * Updated directconnect * Updated protractor * Added firfox launcher * Removed directConnect * Reverting back to directConnect * Removed firefox * Re-added firefox * Accepting insecure certs * Enabled directconnect * use chrome with chromOptions in protractor-dev.conf.js * add sources to travis.yml * add dist: trusty * Removed tsconfig paths * Update typescript-loader * Simpler method for avoiding directories * As ts-node option and fix e2e test
* Using omnibarConfigMap for envid/svcid * Fixing implicit any
* Fixed codelyzer path * Added node_modules to excludes * Readded node_modules
* Added ignore pattern to component generator * Component generator should ignore public folder * Updated ignore pattern
* Do not check directories * Added nodir option
* Updated branch to master * Fixed bug with ignore components pattern * Updated unit tests
* Update CHANGELOG.md * Update package.json
* Fixed type error * Updated skyux * Updated skyux
* Fixed type error * Updated skyux * Updated skyux * Update package.json * Update CHANGELOG.md
* Fixed typo in OmnibarConfigMap. Allowing querystring params to be case insensitive * Test cleanup * Removed unnecessary mapping functionality
* Removed tslint-loader * Created custom sky-tslint loader
* Updated changelog, version * Update CHANGELOG.md * Update CHANGELOG.md
* Updated package dependencies * Update skyux version * use appropriate template branch
* Updates for rc.5
Blackbaud-BobbyEarl
changed the title
|
Thanks for the review @blackbaud-brandonstirnaman, if you have any free time, this is available for another one. |
Blackbaud-BobbyEarl
changed the title
| @@ -6,6 +6,7 @@ | |||
| "requireLineFeedAtFileEnd": null, | |||
| "requireTrailingComma": null, | |||
| "requirePaddingNewLinesBeforeLineComments": null, | |||
| "validateLineBreaks": null, | |||
There was a problem hiding this comment.
This rule validates LF vs CRLF. Since we don't specify default line-endings via a .gitattributes file, this rule will fail when someone on Windows attempts to contribute code.
| @@ -5,7 +5,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "coverage": "npm run coverage:builder && npm run coverage:runtime && npm run coverage:src-app", | |||
| "coverage:builder": "istanbul cover --report=html --dir=./coverage/builder jasmine JASMINE_CONFIG_PATH=jasmine.json", | |||
| "coverage:builder": "istanbul cover --report=html --dir=./coverage/builder ./node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=jasmine.json", | |||
There was a problem hiding this comment.
Following instructions from https://github.com/gotwarlost/istanbul#usage-on-windows
Blackbaud-TerryHelems
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing blackbaud/skyux2#400