Updates to support Windows

.jscsrc

@@ -6,6 +6,7 @@
     "requireLineFeedAtFileEnd": null,
     "requireTrailingComma": null,
     "requirePaddingNewLinesBeforeLineComments": null,
+    "validateLineBreaks": null,
     "excludeFiles": [
       "coverage/**"
     ]

config/protractor/protractor-dev.conf.js

@@ -7,6 +7,7 @@ const SpecReporter = require('jasmine-spec-reporter').SpecReporter;
 
 const common = require('../../e2e/shared/common');
 const commonConfig = require('./protractor.conf');
+
 let config = {
   specs: [
     path.join(process.cwd(), 'e2e', '**', '*.e2e-spec.js')
@@ -20,8 +21,8 @@ let config = {
     return new Promise((resolve, reject) => {
       const url = 'https://github.com/blackbaud/skyux-template';
       const branch = 'update-angular425';
-      common.exec(`rm`, [`-rf`, `${common.tmp}`])
-
+
+      common.rimrafPromise(common.tmp)
         .then(() => common.exec(`git`, [
           `clone`,
           `-b`,
@@ -30,7 +31,6 @@ let config = {
           url,
           common.tmp
         ]))
-
         .then(() => common.exec(`npm`, [`i`, '--only=prod'], common.cwdOpts))
         .then(() => common.exec(`npm`, [`i`, `../`], common.cwdOpts))
         .then(resolve)
@@ -44,7 +44,7 @@ let config = {
     common.afterAll();
 
     return new Promise((resolve, reject) => {
-      common.exec(`rm`, [`-rf`, `${common.tmp}`])
+      common.rimrafPromise(common.tmp)
         .then(resolve)
         .catch(reject);
     });

e2e/shared/common.js

@@ -5,9 +5,10 @@
 const fs = require('fs');
 const path = require('path');
 const merge = require('merge');
+const rimraf = require('rimraf');
 const portfinder = require('portfinder');
 const HttpServer = require('http-server');
-const childProcessSpawn = require('child_process').spawn;
+const childProcessSpawn = require('cross-spawn');
 
 const tmp = './.e2e-tmp/';
 const cwdOpts = { cwd: tmp };
@@ -130,7 +131,7 @@ function prepareBuild(config) {
   writeConfig(config);
 
   return new Promise((resolve, reject) => {
-    exec(`rm`, [`-rf`, `${tmp}/dist`])
+    rimrafPromise(path.join(tmp, 'dist'))
       .then(() => exec(`node`, [cliPath, `build`], cwdOpts))
       .then(serve)
       .then(resolve)
@@ -163,6 +164,21 @@ function resetConfig() {
   writeConfig(skyuxConfigOriginal);
 }
 
+/**
+ * Wraps the rimraf command in a promise.
+ */
+function rimrafPromise(dir) {
+  return new Promise((resolve, reject) => {
+    rimraf(dir, err => {
+      if (err) {
+        reject(err);
+      } else {
+        resolve();
+      }
+    });
+  });
+}
+
 /**
  * Writes the specified json to the skyuxconfig.json file
  */
@@ -268,6 +284,7 @@ module.exports = {
   getExitCode: getExitCode,
   prepareBuild: prepareBuild,
   prepareServe: prepareServe,
+  rimrafPromise: rimrafPromise,
   tmp: tmp,
   writeAppFile: writeAppFile,
   removeAppFile: removeAppFile,

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "coverage": "npm run coverage:builder && npm run coverage:runtime && npm run coverage:src-app",
-    "coverage:builder": "istanbul cover --report=html --dir=./coverage/builder jasmine JASMINE_CONFIG_PATH=jasmine.json",
+    "coverage:builder": "istanbul cover --report=html --dir=./coverage/builder ./node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=jasmine.json",
     "coverage:runtime": "node ./utils/cli-test.js dev-runtime",
     "coverage:src-app": "node ./utils/cli-test.js dev-src-app",
     "e2e": "webdriver-manager update && protractor ./config/protractor/protractor-dev.conf.js",
@@ -96,11 +96,13 @@
     "zone.js": "0.8.10"
   },
   "devDependencies": {
+    "cross-spawn": "5.1.0",
     "istanbul": "0.4.5",
     "jasmine": "2.6.0",
     "jscs": "3.0.7",
     "jshint": "2.9.4",
     "mock-require": "2.0.2",
-    "proxyquire": "1.8.0"
+    "proxyquire": "1.8.0",
+    "rimraf": "2.6.1"
   }
 }

test/sky-pages-route-generator.spec.js

@@ -101,7 +101,7 @@ describe('SKY UX Builder route generator', () => {
       }
     });
 
-    expect(suppliedPattern).toEqual('my-custom-src/my-custom-pattern');
+    expect(suppliedPattern).toEqual(path.join('my-custom-src', 'my-custom-pattern'));
   });
 
   it('should handle windows guard paths correctly', () => {
@@ -180,7 +180,7 @@ describe('SKY UX Builder route generator', () => {
       @Injectable() export class Guard2 {}
     `);
 
-    let file = 'my-custom-src/my-custom-route/index.guard.ts';
+    let file = path.join('my-custom-src', 'my-custom-route', 'index.guard.ts');
     expect(() => generator.getRoutes({
       runtime: {
         srcPath: 'my-custom-src/',