Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

RC > Config params as an object; always decode URL params #421

Merged
merged 5 commits into from
Jul 3, 2018

Conversation

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the base branch from master to rc-2.0.0 June 20, 2018 20:07
@codecov-io
Copy link

codecov-io commented Jun 20, 2018

Codecov Report

Merging #421 into rc-2.0.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rc-2.0.0    #421      +/-   ##
===========================================
- Coverage      99.3%   99.3%   -0.01%     
===========================================
  Files            73      73              
  Lines          1881    1876       -5     
  Branches        290     288       -2     
===========================================
- Hits           1868    1863       -5     
  Misses           13      13
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 95.45% <100%> (-0.08%) ⬇️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/params.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0fac9...103c8d1. Read the comment docs.

@@ -1 +1,6 @@
export type SkyuxConfigParams = string[] | { [key: string]: boolean | { value?: any; required?: boolean } };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not necessarily opposed, just don't recall talking explicitly about it. Was the intention here to remove support for an array of strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blackbaud-BobbyEarl I may've misunderstood the issue, but I took it to mean that SkyConfigParams would always be considered an object. This would make it easier to document and support, instead of having two different types.

https://github.com/blackbaud/skyux2/projects/9#card-10723415

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're right. That's a good catch regarding deprecating that syntax. Sorry for the confusion.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 40e8b94 into rc-2.0.0 Jul 3, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the rc-config-params branch July 3, 2018 20:22
Blackbaud-DiHuynh pushed a commit to Blackbaud-DiHuynh/skyux-builder that referenced this pull request Jul 10, 2020
* RC > Removed all references to SKY UX, changed dependency structure (blackbaud#419)

* RC > Updated TSLint rules (blackbaud#422)

* Removed legacy omnibar (blackbaud#420)

* RC > Config params as an object; always decode URL params (blackbaud#421)

* RC > Always provide `envId` regardless of permission scope (blackbaud#427)

* RC > Allow SPAs to bundle stylesheets that live outside of `src/app` (blackbaud#428)

* RC > Adjusted dev dependencies (blackbaud#429)

* RC > Fixed ts-helpers for build (blackbaud#434)

* RC > Update from master (blackbaud#425)

* RC > Removed global RxJS imports (blackbaud#438)

* RC > Replaced error component with iframe (blackbaud#436)

* RC > Removed SKY CSS import (blackbaud#443)

* RC > Instrument different directory for libraries (blackbaud#448)

* RC > Do not ignore Protractor Error 199 (blackbaud#435)

* RC > Merged master (blackbaud#444)

* RC > Merge master (blackbaud#454)

* RC > Upgrade Angular, RxJS, TypeScript (blackbaud#495)

* RC > Moved auth-client to peer dependency; fixed `skyux watch` (blackbaud#503)

* Disabled webpack host check (blackbaud#505)

* Replaced JSHint with ESLint. (blackbaud#506)

* RC > Merge master (blackbaud#508)

* RC > Changed name of NPM package (blackbaud#501)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants