This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
RC > Always provide envId regardless of permission scope
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc-2.0.0 #427 +/- ##
===========================================
+ Coverage 99.3% 99.3% +<.01%
===========================================
Files 73 73
Lines 1876 1878 +2
Branches 288 289 +1
===========================================
+ Hits 1863 1865 +2
Misses 13 13
Continue to review full report at Codecov.
|
runtime/auth-http.ts
Outdated
| tokenArgs.permissionScope = this.permissionScope; | ||
| } | ||
|
|
||
| // Always provide the environment ID. | ||
| tokenArgs.envId = this.getEnvId(); |
There was a problem hiding this comment.
I think we still want to only add this if envId exists.
There was a problem hiding this comment.
@Blackbaud-BobbyEarl Would it be enough to wrap this assignment in an if statement? Trying to understand where I'm getting this wrong...
const envId = this.getEnvId();
if (envId) {
tokenArgs.envId = envId;
}
There was a problem hiding this comment.
Yep. Wrapping in an if is what we need.
Blackbaud-BobbyEarl
approved these changes
Jul 6, 2018
Blackbaud-DiHuynh
pushed a commit
to Blackbaud-DiHuynh/skyux-builder
that referenced
this pull request
Jul 10, 2020
* RC > Removed all references to SKY UX, changed dependency structure (blackbaud#419) * RC > Updated TSLint rules (blackbaud#422) * Removed legacy omnibar (blackbaud#420) * RC > Config params as an object; always decode URL params (blackbaud#421) * RC > Always provide `envId` regardless of permission scope (blackbaud#427) * RC > Allow SPAs to bundle stylesheets that live outside of `src/app` (blackbaud#428) * RC > Adjusted dev dependencies (blackbaud#429) * RC > Fixed ts-helpers for build (blackbaud#434) * RC > Update from master (blackbaud#425) * RC > Removed global RxJS imports (blackbaud#438) * RC > Replaced error component with iframe (blackbaud#436) * RC > Removed SKY CSS import (blackbaud#443) * RC > Instrument different directory for libraries (blackbaud#448) * RC > Do not ignore Protractor Error 199 (blackbaud#435) * RC > Merged master (blackbaud#444) * RC > Merge master (blackbaud#454) * RC > Upgrade Angular, RxJS, TypeScript (blackbaud#495) * RC > Moved auth-client to peer dependency; fixed `skyux watch` (blackbaud#503) * Disabled webpack host check (blackbaud#505) * Replaced JSHint with ESLint. (blackbaud#506) * RC > Merge master (blackbaud#508) * RC > Changed name of NPM package (blackbaud#501)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/blackbaud/skyux2/projects/9#card-10723204