This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix missing imports #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 18 +3
Lines 250 269 +19
Branches 44 44
=====================================
+ Hits 250 269 +19
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
previously approved these changes
Mar 18, 2019
Blackbaud-AlexKingman
suggested changes
Mar 18, 2019
skyuxconfig.json
Outdated
| @@ -5,6 +5,9 @@ | |||
| "skyuxModules": [ | |||
| "SkyErrorModule" | |||
| ], | |||
| "moduleAliases": { | |||
| "@skyux/core": "./src/app/public" | |||
There was a problem hiding this comment.
This is causing my a circular dependency on my local skyux serve. It looks like the culprit is i18nModule which is importing SkyAppWindowRef from @skyux/core.
There was a problem hiding this comment.
Fix for the @skyux/i18n library incoming...
Blackbaud-AlexKingman
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we're not importing
i18nor providing our custom pipe!