Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fix missing imports #72

Merged
merged 5 commits into from
Mar 20, 2019
Merged

Fix missing imports #72

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1bb388
Fix missing imports
Blackbaud-SteveBrush Mar 18, 2019
ea48dfb
Merge branch 'master' into fix-i18n-export
Blackbaud-SteveBrush Mar 18, 2019
fa206b9
Merge branch 'master' into fix-i18n-export
Blackbaud-AlexKingman Mar 18, 2019
8f5b496
Update version of Builder
Blackbaud-SteveBrush Mar 19, 2019
c01556d
Remove alias
Blackbaud-SteveBrush Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions skyuxconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"skyuxModules": [
"SkyErrorModule"
],
"moduleAliases": {
"@skyux/core": "./src/app/public"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing my a circular dependency on my local skyux serve. It looks like the culprit is i18nModule which is importing SkyAppWindowRef from @skyux/core.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the @skyux/i18n library incoming...

},
"plugins": [
"@skyux-sdk/builder-plugin-skyux"
],
Expand Down
6 changes: 6 additions & 0 deletions src/app/public/modules/numeric/numeric.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import {
DecimalPipe
} from '@angular/common';

import {
SkyI18nModule
} from '@skyux/i18n';

import {
SkyCoreResourcesModule
} from '../shared';
Expand All @@ -26,9 +30,11 @@ import {
providers: [
CurrencyPipe,
DecimalPipe,
SkyNumericPipe,
SkyNumericService
],
imports: [
SkyI18nModule,
SkyCoreResourcesModule
],
exports: [
Expand Down
31 changes: 6 additions & 25 deletions src/app/public/modules/numeric/numeric.pipe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,14 @@
import {
CurrencyPipe,
DecimalPipe
} from '@angular/common';

import {
TestBed
} from '@angular/core/testing';

import {
SkyLibResourcesService
} from '@skyux/i18n/modules/i18n/lib-resources.service';
SkyNumericModule
} from './numeric.module';

import {
SkyLibResourcesTestService
} from '@skyux/i18n/testing/lib-resources-test.service';
NumericOptions
} from './numeric.options';

import {
SkyNumericPipe
Expand All @@ -23,10 +18,6 @@ import {
SkyNumericService
} from './numeric.service';

import {
NumericOptions
} from './numeric.options';

describe('Numeric pipe', () => {
let pipe: any;
let numericService: any;
Expand All @@ -39,18 +30,8 @@ describe('Numeric pipe', () => {
expectedConfig.iso = 'USD';

TestBed.configureTestingModule({
declarations: [
SkyNumericPipe
],
providers: [
CurrencyPipe,
DecimalPipe,
SkyNumericPipe,
SkyNumericService,
{
provide: SkyLibResourcesService,
useClass: SkyLibResourcesTestService
}
imports: [
SkyNumericModule
]
});

Expand Down