-
Notifications
You must be signed in to change notification settings - Fork 65
Fix toasts appearing under modal #1756
Fix toasts appearing under modal #1756
Conversation
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 9e7f8e9 (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 410 410
Lines 8585 8585
Branches 1267 1267
=======================================
Hits 8584 8584
Misses 1 1 Continue to review full report at Codecov.
|
@@ -10,6 +10,7 @@ | |||
display: flex; | |||
flex-direction: row; | |||
align-items: center; | |||
z-index: $sky-toast-z-index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're setting the z-index
of the parent "toaster" component, this is redundant.
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: c378941 (Please note that this is a fully automated comment.) |
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: df9b9b8 (Please note that this is a fully automated comment.) |
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: c15f7b9 (Please note that this is a fully automated comment.) |
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: c6ee354 (Please note that this is a fully automated comment.) |
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 61433f0 (Please note that this is a fully automated comment.) |
Added z-indexes to toaster and toast so they appear over the modal background and can be closed while the modal is open.
Resolves: #1708