Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fix toasts appearing under modal #1756

Conversation

Blackbaud-JackMcElhinney
Copy link
Contributor

Added z-indexes to toaster and toast so they appear over the modal background and can be closed while the modal is open.

Resolves: #1708

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 9e7f8e9
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/396472348

(Please note that this is a fully automated comment.)

@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #1756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1756   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         410      410           
  Lines        8585     8585           
  Branches     1267     1267           
=======================================
  Hits         8584     8584           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab4145...61433f0. Read the comment docs.

@@ -10,6 +10,7 @@
display: flex;
flex-direction: row;
align-items: center;
z-index: $sky-toast-z-index;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're setting the z-index of the parent "toaster" component, this is redundant.

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: c378941
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/399712301

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: df9b9b8
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/404916729

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: c15f7b9
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/405039003

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: c6ee354
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/405064621

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 61433f0
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/405095118

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit da7d277 into blackbaud:master Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sky Toast Component behind modal
4 participants