Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fix toasts appearing under modal #1756

Merged
merged 7 commits into from
Jul 18, 2018
Merged

Fix toasts appearing under modal #1756

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8ce3115
toasts show at same z-index as modal
Blackbaud-JackMcElhinney Jun 25, 2018
9e7f8e9
edit comment
Blackbaud-JackMcElhinney Jun 25, 2018
c378941
remove z-index on toast
Blackbaud-JackMcElhinney Jul 3, 2018
df9b9b8
Merge branch 'master' into fix-toast-under-modal
Blackbaud-SteveBrush Jul 17, 2018
c15f7b9
Merge branch 'master' into fix-toast-under-modal
Blackbaud-SteveBrush Jul 17, 2018
c6ee354
Merge branch 'master' into fix-toast-under-modal
Blackbaud-SteveBrush Jul 17, 2018
61433f0
Merge branch 'master' into fix-toast-under-modal
Blackbaud-SteveBrush Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/modules/toast/toast.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
display: flex;
flex-direction: row;
align-items: center;
z-index: $sky-toast-z-index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're setting the z-index of the parent "toaster" component, this is redundant.


button {
margin-left: auto;
Expand Down
1 change: 1 addition & 0 deletions src/modules/toast/toaster.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@
padding-bottom: $sky-margin-double;
padding-right: $sky-margin-double;
padding-top: 50px;
z-index: $sky-toaster-z-index;
}
5 changes: 5 additions & 0 deletions src/scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ $sky-fluid-grid-columns: 12 !default;
$sky-flyout-z-index: 1001 !default; // omnibar is 1000, help is 9999:
// end flyout

// begin toast
$sky-toaster-z-index: 1051 !default; // modal is 1050:
$sky-toast-z-index: 1052 !default;
// end toast

// begin grid
$sky-grid-odd-background-color: $sky-color-gray-01 !default;
$sky-grid-even-background-color: $sky-color-white !default;
Expand Down