This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Ability to change route name using pageTitle, navTitle
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Blackbaud-SteveBrush
commented
May 18, 2017
•
Blackbaud-SteveBrush
commented
- Requires skyux-builder-plugin-stache-route-metadata.
- Need to think about how we can also manage route order using this method (in a different PR)
Blackbaud-SteveBrush
changed the title
pageTitlepageTitle
Blackbaud-SteveBrush
requested review from
blackbaud-brandonhare and
Blackbaud-BrandonJones
and removed request for
blackbaud-brandonhare
Blackbaud-SteveBrush
changed the title
pageTitlepageTitle, navTitle
Blackbaud-BrandonJones
previously approved these changes
May 24, 2017
package.json
Outdated
| @@ -33,11 +33,12 @@ | |||
| "@blackbaud/skyux": "2.0.0-beta.27", | |||
| "@blackbaud/skyux-builder-plugin-stache-code-block": "1.0.0", | |||
| "@blackbaud/skyux-builder-plugin-stache-include": "1.0.0", | |||
| "@blackbaud/skyux-builder-plugin-stache-route-metadata": "blackbaud/skyux-builder-plugin-stache-route-metadata#unit-tests", | |||
There was a problem hiding this comment.
are we pointing to #unit-tests on purpose?
There was a problem hiding this comment.
Yeah, until y'all approve that PR, too :)
package.json
Outdated
| "prismjs": "1.6.0", | ||
| "smoothscroll-polyfill": "0.3.5" | ||
| }, | ||
| "devDependencies": { | ||
| "@blackbaud/skyux-builder": "1.0.0-beta.25", | ||
| "@blackbaud/skyux-builder": "blackbaud/skyux-builder#plugin-config", |
There was a problem hiding this comment.
also plugin-config?
There was a problem hiding this comment.
This can be updated. One minute...
| @@ -0,0 +1,5 @@ | |||
| // The contents of this file are automatically generated by | |||
There was a problem hiding this comment.
Good use of comments!
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 43 44 +1
Lines 566 584 +18
Branches 48 51 +3
=====================================
+ Hits 566 584 +18
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.