This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Ability to change route name using pageTitle
, navTitle
#166
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d822dee
Added sample directories
Blackbaud-SteveBrush f30561c
Added pages
Blackbaud-SteveBrush b1c6896
Removed console logs
Blackbaud-SteveBrush f12a80d
Fixed unit tests
Blackbaud-SteveBrush 82b4aa7
Merge branch 'master' into feature-route-metadata
Blackbaud-SteveBrush dcd1e25
Updated version of skyux-builder
Blackbaud-SteveBrush a91568c
Merge branch 'feature-route-metadata' of https://github.com/blackbaud…
Blackbaud-SteveBrush afb703b
Update package.json
Blackbaud-SteveBrush f52072c
Update package.json
Blackbaud-SteveBrush da56e76
Merged master
Blackbaud-SteveBrush e78c653
100% code coverage
Blackbaud-SteveBrush 03d3706
Merge branch 'master' into feature-route-metadata
Blackbaud-SteveBrush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,11 +33,12 @@ | |
"@blackbaud/skyux": "2.0.0-beta.27", | ||
"@blackbaud/skyux-builder-plugin-stache-code-block": "1.0.0", | ||
"@blackbaud/skyux-builder-plugin-stache-include": "1.0.0", | ||
"@blackbaud/skyux-builder-plugin-stache-route-metadata": "blackbaud/skyux-builder-plugin-stache-route-metadata#unit-tests", | ||
"prismjs": "1.6.0", | ||
"smoothscroll-polyfill": "0.3.5" | ||
}, | ||
"devDependencies": { | ||
"@blackbaud/skyux-builder": "1.0.0-beta.25", | ||
"@blackbaud/skyux-builder": "blackbaud/skyux-builder#plugin-config", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also plugin-config? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be updated. One minute... |
||
"codelyzer": "2.0.0-beta.1", | ||
"fs-extra": "3.0.1", | ||
"glob": "7.1.1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<!-- Sidebar route name will use the directory name --> | ||
<stache> | ||
|
||
</stache> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<!-- Sidebar route name will use the directory name --> | ||
<stache> | ||
|
||
</stache> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<!-- Sidebar route name will be pageTitle --> | ||
<stache pageTitle="Advanced"> | ||
|
||
</stache> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// The contents of this file are automatically generated by | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good use of comments! |
||
// https://github.com/blackbaud/skyux-builder-plugin-stache-route-metadata | ||
export class StacheRouteMetadataService { | ||
public routes: any[]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,10 @@ export class AppNavComponent { | |
{ | ||
name: 'Home', | ||
path: '/' | ||
}, | ||
{ | ||
name: 'Learn', | ||
path: '/learn' | ||
} | ||
]; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we pointing to #unit-tests on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, until y'all approve that PR, too :)