-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[legacy-framework] Print helpful error if try to use CLI commands outside of blitz app #203
Merged
flybayer
merged 13 commits into
blitz-js:canary
from
Zeko369:189-checkIfRunningInsideBlitzApp
Apr 28, 2020
Merged
[legacy-framework] Print helpful error if try to use CLI commands outside of blitz app #203
flybayer
merged 13 commits into
blitz-js:canary
from
Zeko369:189-checkIfRunningInsideBlitzApp
Apr 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flybayer
reviewed
Apr 25, 2020
Sweeet! Two things:
Thank you so much! |
…y checked in init hook
This is beautiful — great work!!! |
flybayer
changed the title
Exit gracefully if outside of blitz app
Print helpful error if try to use CLI commands outside of blitz app
Apr 28, 2020
@Zeko369 i think we have commands that check for this manually, can you follow up and convert those usages to use the new utils? |
@aem you pushed the new utils? |
Ah sorry my comment was a bit unclear. Since this hook/util you added handles it for all commands, can you remove any checks for |
itsdillon
changed the title
Print helpful error if try to use CLI commands outside of blitz app
[legacy-framework] Print helpful error if try to use CLI commands outside of blitz app
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
What's the reason for the change? ❓
Closes: blitz-js/legacy-framework#892
What are the changes and their implications? ⚙️
Check if inside of blitz app
Does this introduce a breaking change?⚠️
Other information
I made it so it checks you're in the root of the project, because although some commands can work throughout the project structure, some fail so we should encourage people to just run it from the root path