[legacy-framework] Add helpful error messages to CLI when trying to use commands outside an app #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y checked in init hook
aem
reviewed
Apr 28, 2020
| const whitelistGlobal = ['new'] | ||
|
|
||
| const hook: Hook<'init'> = async function (options) { | ||
| // Bug with oclif |
There was a problem hiding this comment.
did you open an issue with their project? would be good to get this fixed at some point
aem
reviewed
Apr 28, 2020
| if (err) { | ||
| switch (message) { | ||
| case IsBlitzRootError.notBlitz: | ||
| this.log( |
There was a problem hiding this comment.
can we use the @blitzjs/server/utils/log utility rather than the Command logger?
aem
reviewed
Apr 28, 2020
aem
reviewed
Apr 28, 2020
flybayer
changed the title
|
Thank you @Zeko369!! |
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Another shot at #203 because of Oclif bug
Breaking change: No, but the same was sad last time 😄