fix(cli): multiselect visibility for light themes#1716
Merged
wendytang merged 1 commit intoblock:mainfrom Mar 24, 2025
Merged
Conversation
vineetjohn
changed the title
vineetjohn
changed the title
vineetjohn
changed the title
Contributor
Author
|
Open to other suggestions on how to improve this. I realize this overloads what the hint argument is used for as a per-item attribute. https://docs.rs/cliclack/latest/cliclack/struct.MultiSelect.html#method.item However, any subsequent 'correct' use of the hint will also fix the same problem. |
vineetjohn
changed the title
vineetjohn
changed the title
vineetjohn
force-pushed
the
improve-toggle-viz
branch
from
c0102ae to
59be120
Compare
Apply the same change to the 'Remove extension' and 'Experiments' dialogs as well # Conflicts: # crates/goose-cli/src/commands/configure.rs
vineetjohn
force-pushed
the
improve-toggle-viz
branch
from
59be120 to
a312612
Compare
wendytang
approved these changes
Mar 21, 2025
tcollier
added a commit
to tcollier/goose
that referenced
this pull request
Mar 24, 2025
* origin/main: feat: Adjust UX of extension installs in V2 settings (block#1836) fix: goose modes styling (block#1833) New toasts (block#1777) feat: bring back install-link-generator which was lost in the extensions-site revamp (block#1832) feat: settings v2 extension add refactor (block#1815) fix: Update link color in chat view for user messages (block#1717) (block#1754) fix windows native uvx (block#1775) fix: correct deep link install link format (block#1830) fix(cli): multiselect visibility for light themes (block#1716) docs: Update styling (block#1831) Refactor top bar (block#1829) Docs: Revamp extensions site (block#1260) fix: extension site not rendering servers (block#1824) feat: add pdf reader (block#1818) fix: fix allowing multiple selectors in goosebench (block#1814) Fix chat width issues (block#1813)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small QoL change to improve visibility when toggling options in a
cliclackmulti-select.This visibility problem only seems to exist for light themes, where there's no visible difference in text colour contrast between the cursor item and the result.
Apply the same change to the 'Remove extension' and 'Experiments' dialogs as well
Multi-select prompt interaction videos
old.mp4
new.mp4